Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57090
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALkpNnQ4L2n=ju==eaVUT0_PB_cChjLdLH=KX5LHRgqo-vTXtA@mail.gmail.com>
References: <CAGMw7vE9t8TimNN8bYXU2zG2fHCoR2P+LN8ZcurREDKPomK1Xg@mail.gmail.com>
	<CAEZPtU5xnhnVdk8Yw0hmxLkdK25TTygFD9Umk5A_ApZgOGVbBg@mail.gmail.com>
	<CAEZPtU5smafux16aOq+vpsght5KY_+JacF8mEqusGzYTuptZZA@mail.gmail.com>
	<alpine.DEB.2.02.1112241154350.27751@whisky.home.derickrethans.nl>
	<CAGMw7vEpvpNju96c7OthFa3-r87X6tPO5goYMR3YWKuTkPvSDw@mail.gmail.com>
	<CAEZPtU6nYTyCN2snxcmOzJ=jULN=HWVROghS2aK6yUj0X3LJ4g@mail.gmail.com>
	<CALkpNnQ4L2n=ju==eaVUT0_PB_cChjLdLH=KX5LHRgqo-vTXtA@mail.gmail.com>
Date: Sat, 24 Dec 2011 16:25:12 +0100
Message-ID: <CAEZPtU58zfhk+-DAaUCWmux=bCxF-+DPHwkBbVV8HRr7EQeXYg@mail.gmail.com>
To: Ilia Alshanetsky <ilia@ilia.ws>
Cc: =?ISO-8859-1?B?QW5kcukgUvhtY2tl?= <ar@ez.no>, 
	David Soria Parra <dsp@php.net>, Stas Malyshev <smalyshev@sugarcrm.com>, Derick Rethans <derick@php.net>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] REQUEST_TIME change in PHP 5.4
From: pierre.php@gmail.com (Pierre Joye)

hi Ilia,

Right but there is a clear BC break here. And yes I really don't like
how datetime deals with that but it is how it is, and it is certainly
the only case where it fails (or almost).

On Sat, Dec 24, 2011 at 4:18 PM, Ilia Alshanetsky <ilia@ilia.ws> wrote:
> In most instances integers and floats can be used interchangeably,
> which is why the patch was written in the way that it was. In the few
> rare cases (int) cast takes care of the trick, there is a substantial
> benefit for timings etc... to have higher precision timestamp
> available at no additional cost. Introducing additional server
> variables just makes things inconsistent, especially this late in the
> release cycle.
>
> On Sat, Dec 24, 2011 at 10:07 AM, Pierre Joye <pierre.php@gmail.com> wrot=
e:
>> On Sat, Dec 24, 2011 at 3:47 PM, Andr=E9 R=F8mcke <ar@ez.no> wrote:
>>
>>> Yes, this is the one from Zeta Components MvcTools.
>>> In eZ Publish it was db based session gc using REQUEST_TIME
>>> and=A0compatibility=A0for potential extensions that might have used thi=
s
>>> variable via eZ Publish
>>> api:=A0https://github.com/ezsystems/ezpublish/commit/3483c623769aa9ed3b=
e7b6f33e3579cf8a8efd45
>>>
>>> In both cases a (int) was added in front of the variable to make sure i=
t
>>> still behaves the same, so=A0not a big deal.
>>> But as also mentioned, changes like this=A0requires patching=A0to
>>> be=A0compatible=A0with 5.4.
>>>
>>> So unless this is done to be inline with some standard on such a server
>>> variable, I would suggest placing microtime on a=A0separate=A0server va=
riable
>>> (since it is indeed useful to have it for time accumulators and perform=
ance
>>> metrics).
>>
>>
>> Right, and that's why I would be in favour of a BC change, maybe by
>> introducing a REQUEST_TIME_FLOAT instead, so people willing to use the
>> float version can still have it while the existing code needs no
>> change.
>>
>> Adding Ilia (who made that change) and the RMs to the list.
>> Cheers,
>> --
>> Pierre
>>
>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org