Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:57080 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58347 invoked from network); 24 Dec 2011 13:46:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Dec 2011 13:46:31 -0000 Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.212.42 mail-vw0-f42.google.com Received: from [209.85.212.42] ([209.85.212.42:53703] helo=mail-vw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 74/DA-16446-EA7D5FE4 for ; Sat, 24 Dec 2011 08:46:22 -0500 Received: by vbbfd1 with SMTP id fd1so8405066vbb.29 for ; Sat, 24 Dec 2011 05:46:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=qNkQ5PMtA1dz2kvg6ZOwpv1gzrPYOuBClLfDE5HMq6w=; b=Ljn3o2FXmkhe+i7P1mi4LoLQh2CP6fschFulT/ej1U3kUb+SaPsFg2iiSnhWfaafbR +LC9VPFmbCc0kXPwkwhKag/ZjiMSFdC1iw8A+8THzPLNzEWCeoXVil/32n90pQ9P4/MS EUyp7RKL+dXrqsP4YmVXh3HcVt43fQy+raho0= Received: by 10.52.20.35 with SMTP id k3mr10374844vde.34.1324734379208; Sat, 24 Dec 2011 05:46:19 -0800 (PST) MIME-Version: 1.0 Sender: laruence@gmail.com Received: by 10.220.3.14 with HTTP; Sat, 24 Dec 2011 05:45:58 -0800 (PST) In-Reply-To: <1324733675.9809.1.camel@guybrush> References: <1324733675.9809.1.camel@guybrush> Date: Sat, 24 Dec 2011 21:45:58 +0800 X-Google-Sender-Auth: ASEsG1HNSRfRujYl4fQq4uSjrZ4 Message-ID: To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= Cc: Derick Rethans , Pierre Joye , Rafael Kassner , PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [Proposal] Remove the tail ws in codes From: laruence@php.net (Laruence) 2011/12/24 Johannes Schl=C3=BCter : > On Sat, 2011-12-24 at 11:56 +0000, Derick Rethans wrote: >> On Sat, 24 Dec 2011, Pierre Joye wrote: >> >> > Laruence refers to the PHP C source code and removing trailing white >> > spaces is a good thing as it is part of our CS. >> > >> > Go ahead Laruence :) >> >> Please don't. Changing whitespace en-masse makes it a royal pain to do >> merges later. Please just fix them when you change the code on that line >> only. > > It's not only bad for merges, also confusing with blame/annotate while > identifying the reason for bug. > hmm, yes, you are right :), actually, I am not saying that I am going to do such behavior, just remind us that we should watch such CS, since there have been lots of tail ws now... :) thanks > johannes > >> Derick >> >> -- >> http://derickrethans.nl | http://xdebug.org >> Like Xdebug? Consider a donation: http://xdebug.org/donate.php >> twitter: @derickr and @xdebug >> > > --=20 Laruence =C2=A0Xinchen Hui http://www.laruence.com/