Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57079
Return-Path: <johannes@schlueters.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 56406 invoked from network); 24 Dec 2011 13:34:45 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 24 Dec 2011 13:34:45 -0000
Authentication-Results: pb1.pair.com header.from=johannes@schlueters.de; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=johannes@schlueters.de; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
X-PHP-List-Original-Sender: johannes@schlueters.de
X-Host-Fingerprint: 217.114.211.66 config.schlueters.de  
Received: from [217.114.211.66] ([217.114.211.66:40279] helo=config.schlueters.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 9E/7A-16446-3F4D5FE4 for <internals@lists.php.net>; Sat, 24 Dec 2011 08:34:44 -0500
Received: from [192.168.2.230] (ppp-93-104-36-154.dynamic.mnet-online.de [93.104.36.154])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(Client did not present a certificate)
	by config.schlueters.de (Postfix) with ESMTPSA id 14B435FAEB;
	Sat, 24 Dec 2011 14:34:39 +0100 (CET)
To: Derick Rethans <derick@php.net>
Cc: Laruence <laruence@php.net>, Pierre Joye <pierre.php@gmail.com>, Rafael
 Kassner <kassner@gmail.com>, PHP Internals <internals@lists.php.net>
In-Reply-To: <alpine.DEB.2.02.1112241155370.27751@whisky.home.derickrethans.nl>
References:
	 <CABBJUperfGV7jqpjHw4sF7KvRSrbD-+Axe=153g-YYT111xEZg@mail.gmail.com>
	 <CA+S5htNKQamqKQkBVRHqUN_UUHhwoTsBiNEUM1rwYC2FpaZ9-Q@mail.gmail.com>
	 <CAEZPtU7o=e6kkwB2Mt9OW5irSk_CJbyXTJ5kpswf_XG_T1UU_Q@mail.gmail.com>
	 <alpine.DEB.2.02.1112241155370.27751@whisky.home.derickrethans.nl>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 24 Dec 2011 14:34:35 +0100
Message-ID: <1324733675.9809.1.camel@guybrush>
Mime-Version: 1.0
X-Mailer: Evolution 2.30.3 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [Proposal] Remove the tail ws in codes
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Sat, 2011-12-24 at 11:56 +0000, Derick Rethans wrote:
> On Sat, 24 Dec 2011, Pierre Joye wrote:
> 
> > Laruence refers to the PHP C source code and removing trailing white
> > spaces is a good thing as it is part of our CS.
> > 
> > Go ahead Laruence :)
> 
> Please don't. Changing whitespace en-masse makes it a royal pain to do 
> merges later. Please just fix them when you change the code on that line 
> only.

It's not only bad for merges, also confusing with blame/annotate while
identifying the reason for bug.

johannes

> Derick
> 
> -- 
> http://derickrethans.nl | http://xdebug.org
> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
> twitter: @derickr and @xdebug
>