Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57069
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain ez.no from 209.85.160.42 cause and error)
MIME-Version: 1.0
In-Reply-To: <6035C633-F740-4218-BAB9-5771E1500BC2@gmail.com>
References: <2095305E-D4E3-4D7E-8218-32EE99688E0C@GMAIL.COM>
 <CAF+90c-Wtok1fnVxokYUFQhbYnMcNDwWWT63F8NDp+JnxCDMew@mail.gmail.com>
 <2C90FB94-38C4-4270-8C6A-B89304BA8ED8@gmail.com> <CAEZPtU6gneOOehrsz-qVifmNxg6tnyLt9hqfnAwKZmfpXdeC9Q@mail.gmail.com>
 <159A7CA2-8561-40DA-9434-CAAE12304DDB@gmail.com> <4EF3B56A.4040809@gmail.com>
 <-2451498990672032588@unknownmsgid> <4EF3BD21.2040301@sugarcrm.com>
 <-6952580475866195972@unknownmsgid> <4EF3C7F7.9010404@sugarcrm.com>
 <4841689055873111589@unknownmsgid> <4EF3D18B.7040900@sugarcrm.com>
 <11CFB4E4-F2DA-4766-AA23-D08180C3910B@gmail.com> <A633CF2D7C7BED41B41F1E64F25507B8068ECEC8F0@MAILR001.mail.lan>
 <CAGMw7vG5+prmvRgJsLOjajSoWmAm6jbkXwV5KiVs0JspWNk_Bg@mail.gmail.com> <6035C633-F740-4218-BAB9-5771E1500BC2@gmail.com>
Date: Sat, 24 Dec 2011 10:40:27 +0100
Message-ID: <CAGMw7vF6EeXDXzVMTvXCNc4KzAq3j0JrGL4E3jZG3EFPCXMr_g@mail.gmail.com>
To: Will Fitch <will.fitch@gmail.com>
Cc: John Crenshaw <johncrenshaw@priacta.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	PHP Developers Mailing List <internals@lists.php.net>, =?UTF-8?B?w4FuZ2VsIEdvbnrDoWxleg==?= <keisial@gmail.com>
Content-Type: multipart/alternative; boundary=e89a8ff1cb181cb95404b4d354bc
Subject: Re: [PHP-DEV] Return Type Hinting for Methods RFC
From: ar@ez.no (=?UTF-8?B?QW5kcsOpIFLDuG1ja2U=?=)

--e89a8ff1cb181cb95404b4d354bc
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 24, 2011 at 8:40 AM, Will Fitch <will.fitch@gmail.com> wrote:

> In the interest of providing options for an ability to mark a method as
> returning null, I have added a new patch here:
> http://www.willfitch.com/php/nullable.patch
>
> This includes a new token "T_NULLABLE".  Here are a few examples:
>
> // This is allowed
> private nullable ArrayIterator getIterator()
> {
>    return null;
> }
>
> // This throws an E_RECOVERABLE_ERROR
> private ArrayIterator getIterator()
> {
>     return null;
> }
>
> The token/identifier can certainly change, but I want to provide the most
> options for the best solution.
>


This looks fine to me, looks more php like then the C# examples.



>
>
> On Dec 23, 2011, at 6:31 PM, Andr=C3=A9 R=C3=B8mcke wrote:
>
> 2011/12/23 John Crenshaw <johncrenshaw@priacta.com>
>
>> > From: Will Fitch [mailto:will.fitch@gmail.com]
>> >
>> > I would like to take this opportunity to query on a consensus:
>> >
>> > Would you prefer to allow methods with type hinted return values to
>> return null at will, or add a marker noting that it *may* return null?
>> >
>> > Example: Return null at will
>> >
>> > public ArrayIterator getIterator()
>> > {
>> >    // something happened, will return null
>> >    return null;
>> > }
>> >
>> > Example: Return only if identified as such
>> >
>> > public ArrayIterator? getIterator()
>> > {
>> >     return null;
>> > }
>>
>> I hate the syntax in the second example (using ?).
>>
>
>
> It looks strange, but easy to get used to. Two examples from C#:
>
> public decimal? Grade { get; set; }
>
> public Nullable<System.DateTime> Time { get; set; }
>
>
>
>
>>
>> IMO allowing null should be the default unless specifically disallowed.
>
>
> I disagree for the reasons mentioned by for instance Robert.
> Type hints should be strict/explicit or not done at all.
>
>
>
For the record; This was not ment as an argument against scalar, and
similar type hints ( object, callable.. ) .
It was an argument against hinting about something and getting
something completely different (null).



Happy xmas!

--e89a8ff1cb181cb95404b4d354bc--