Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57021
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender)
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=iso-8859-1
In-Reply-To: <4EF37C29.1010206@php.net>
Date: Thu, 22 Dec 2011 14:22:57 -0500
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <9FA7F250-468A-47E7-B2B4-977C5B658B4F@gmail.com>
References: <2095305E-D4E3-4D7E-8218-32EE99688E0C@GMAIL.COM> <CAF+90c-Wtok1fnVxokYUFQhbYnMcNDwWWT63F8NDp+JnxCDMew@mail.gmail.com> <2C90FB94-38C4-4270-8C6A-B89304BA8ED8@gmail.com> <CAEZPtU6gneOOehrsz-qVifmNxg6tnyLt9hqfnAwKZmfpXdeC9Q@mail.gmail.com> <159A7CA2-8561-40DA-9434-CAAE12304DDB@gmail.com> <005701ccc0b3$58c8dee0$0a5a9ca0$@alliantinternet.com> <CALtuQzD5EuZ+a66-P4opfd7CyijKkxBLOrBkvn1xnMXoB0cLxw@mail.gmail.com> <20111222145159.GY25857@alliantinternet.com> <006101ccc0ba$46b81160$d4283420$@alliantinternet.com> <CAF=va1Vv_T3RVBhTbvJv+mCqOTpEx3LN1NtFk8PumwjHHPZWxw@mail.gmail.com> <4EF379D8.9000206@lerdorf.com> <4EF37C29.1010206@php.net>
To: Sebastian Bergmann <sebastian@php.net>
Subject: Re: [PHP-DEV] Return Type Hinting for Methods RFC
From: will.fitch@gmail.com (Will Fitch)


On Dec 22, 2011, at 1:51 PM, Sebastian Bergmann wrote:

> Am 22.12.2011 19:41, schrieb Rasmus Lerdorf:
>> This is not a step forward. If the author of age_check() really =
doesn't
>> want to accept type-juggled arguments, then it is easy enough to do a
>> strict type check in the function itself. This puts the effort in the
>> correct place and doesn't encourage this type of coding.
>=20
> Putting such code into the "correct" place does not change the problem
> that you and Stas describe
>=20
>     function age_check($age)
>     {
>         if (!is_int($age)) {
>             throw new InvalidArgumentException;
>         }
>     }
>=20
> With the above code, the caller needs to cast and the writer of the
> age_check() function has to copy/paste/adapt these checks to all the
> correct places ...

There are cases, such as the one you pointed out, that requires type =
casting.  We're just trying to point out a situation where, if scalars =
were allowed to be typed, would produce code littered with type casts.  =
Point taken though.

>=20
> I am not advocating type hints for scalars, I am just saying that this
> argument is not really a good one against it.
>=20
> --=20
> Sebastian Bergmann                    Co-Founder and Principal =
Consultant
> http://sebastian-bergmann.de/                           =
http://thePHP.cc/
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20