Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:57016
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=iso-8859-1
In-Reply-To: <4EF379D8.9000206@lerdorf.com>
Date: Thu, 22 Dec 2011 14:18:04 -0500
Cc: Keloran <ava3ar@gmail.com>,
 Dmitri Snytkine <dsnytkine@ultralogistics.com>,
 Alain Williams <addw@phcomp.co.uk>,
 internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <3F793B30-19EA-4444-A976-C8CB3CAAD156@gmail.com>
References: <2095305E-D4E3-4D7E-8218-32EE99688E0C@GMAIL.COM> <CAF+90c-Wtok1fnVxokYUFQhbYnMcNDwWWT63F8NDp+JnxCDMew@mail.gmail.com> <2C90FB94-38C4-4270-8C6A-B89304BA8ED8@gmail.com> <CAEZPtU6gneOOehrsz-qVifmNxg6tnyLt9hqfnAwKZmfpXdeC9Q@mail.gmail.com> <159A7CA2-8561-40DA-9434-CAAE12304DDB@gmail.com> <005701ccc0b3$58c8dee0$0a5a9ca0$@alliantinternet.com> <CALtuQzD5EuZ+a66-P4opfd7CyijKkxBLOrBkvn1xnMXoB0cLxw@mail.gmail.com> <20111222145159.GY25857@alliantinternet.com> <006101ccc0ba$46b81160$d4283420$@alliantinternet.com> <CAF=va1Vv_T3RVBhTbvJv+mCqOTpEx3LN1NtFk8PumwjHHPZWxw@mail.gmail.com> <4EF379D8.9000206@lerdorf.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Subject: Re: [PHP-DEV] Return Type Hinting for Methods RFC
From: will.fitch@gmail.com (Will Fitch)

On Dec 22, 2011, at 1:41 PM, Rasmus Lerdorf wrote:

> On 12/22/2011 07:08 AM, Keloran wrote:
>> i would love to see this expanded aswell (the way type hinting on =
function
>> variables was supposed to be), so that it could be
>>=20
>> string, int
>>=20
>> e.g.
>> function int test(bool $tester) {
>> if ($tester) { return 5; }
>> return 99;
>> }
>=20
> Return type hinting needs to be aligned with parameter type hinting, =
and
> as has been pointed out many times on this list, type hinting for
> interchangable scalar types is a really bad idea. It will push all =
type
> checking up to the caller of the underlying functions/methods. PHP is
> primarily a Web scripting language and the Web isn't typed. Having =
stuff
> like this break:

Have you taken a look at the RFC and/or patch?  This functionality is =
exactly aligned with parameter type hinting.  Only classes, arrays and =
callables are allowed types.   I agree 100% on scalars.

>=20
> if(age_check($_POST['age'])) { do_stuff(); }
>=20
> because the author of the age_check() function added an int type hint
> just doesn't make any sense. It would cause everyone to have to start
> casting things everywhere, just in case. eg.
>=20
> if(age_check((int)$_POST['age'])) { do_stuff(); }
>=20
> This is not a step forward. If the author of age_check() really =
doesn't
> want to accept type-juggled arguments, then it is easy enough to do a
> strict type check in the function itself. This puts the effort in the
> correct place and doesn't encourage this type of coding.

It absolutely isn't.  I'm also against the class casting RFC which =
would, in effect, do this very same thing.

>=20
> -Rasmus
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20