Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56899
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1323737529.5219.36.camel@guybrush>
References: <9570D903A3BECE4092E924C2985CE485399554D7@MBX202.domain.local>
 <7070130643313812382@unknownmsgid> <9570D903A3BECE4092E924C2985CE4853995589C@MBX202.domain.local>
 <CAEZPtU5P60Xip0GbUD=YPoiUiV5sOYU2qeMfoUF=QhcokpBK5g@mail.gmail.com>
 <9570D903A3BECE4092E924C2985CE48539955910@MBX202.domain.local>
 <CAEZPtU6Hj4_bMM_L5xxOvAF6daqJHPGWcOzXreh-JAOtf5CZzQ@mail.gmail.com>
 <9570D903A3BECE4092E924C2985CE4853995598C@MBX202.domain.local> <1323737529.5219.36.camel@guybrush>
Date: Mon, 12 Dec 2011 20:10:35 -0500
Message-ID: <CAFp73Xs+AQ=FzZHdC=sHykZ6z6JzLYNynqs3DmqqUpVbpS6nuw@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: Clint M Priest <cpriest@zerocue.com>, Pierre Joye <pierre.php@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Accessors v2 Patch
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

Hi,

I don't see how we could possibly do as option 1.
The structure would be weird, because considering I'm looking for an
specific ReflectionMethod that matches a property name, I'd also be
able to call it through invoke, but also regularly through
$obj->Setter($value);
Since I don't see in the match as possible to be executed as the
second possibility, I'd rather bring to a more centralized approach.

$reflProperty =3D $reflClass->getProperty('Hours');
$reflProperty->hasGetter() =3D=3D=3D true
$reflProperty->hasSetter() =3D=3D=3D true

Also,

$reflProperty->setValue($object, $value); would call the Setter method
as well as
$reflProperty->getValue($object) would call the Getter method

It seems the most consistent and centralized approach.


Regards,

2011/12/12 Johannes Schl=C3=BCter <johannes@schlueters.de>:
> On Mon, 2011-12-12 at 01:01 +0000, Clint M Priest wrote:
>> To be complete I should probably add something to the reflection system =
as well. =C2=A0At present the getters/setters would show up as functions.
>>
>> What would be preferable?
>> 1) Show up as regular functions and let users fend for themselves?
>> 2) Hide from getMethods() and:
>> =C2=A0 2.1) Provide getAccessors() - Probably returning a new Reflection=
PropertyAccessor class?
>> =C2=A0 2.2) Provide getGetters(), getSetters()
>> 3) Modify ReflectionProperty to include hasGetter() and hasSetter()
>>
>> Comments?
>
> Reflection in PHP typically is leaking the implementation details
> typically quite a lot instead of abstracting things away (interfaces and
> Traits are ReflectionClass instances etc.)
>
> I didn't look at the implementation but if these accessors are
> implemented as methods (especially if it can be called just like one) I
> would go for approach 1) and probably mark with a flag. For everything
> else we'd probably have to clean-u reflection to leak less details to
> make sense.
>
> johannes
>
>> -----Original Message-----
>> From: Pierre Joye [mailto:pierre.php@gmail.com]
>> Sent: Sunday, December 11, 2011 6:47 PM
>> To: Clint M Priest
>> Cc: internals@lists.php.net
>> Subject: Re: [PHP-DEV] Accessors v2 Patch
>>
>> oh right, I missed them. Yes, so it is covered as well :)
>>
>> On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest <cpriest@zerocue.com> wr=
ote:
>> > There are already two tests against private read and private write, sh=
ould I add two for protected as well?
>>
>> Cheers,
>> --
>> Pierre
>>
>> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Guilherme Blanco
MSN: guilhermeblanco@hotmail.com
GTalk: guilhermeblanco
Toronto - ON/Canada