Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56876 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 31512 invoked from network); 12 Dec 2011 01:01:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Dec 2011 01:01:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=cpriest@zerocue.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=cpriest@zerocue.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zerocue.com designates 74.115.204.54 as permitted sender) X-PHP-List-Original-Sender: cpriest@zerocue.com X-Host-Fingerprint: 74.115.204.54 relay-hub202.domainlocalhost.com Received: from [74.115.204.54] ([74.115.204.54:5392] helo=relay-hub202.domainlocalhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CB/06-21075-E7255EE4 for ; Sun, 11 Dec 2011 20:01:51 -0500 Received: from MBX202.domain.local ([169.254.2.249]) by HUB202.domain.local ([74.115.204.52]) with mapi id 14.01.0289.001; Sun, 11 Dec 2011 20:01:46 -0500 To: Pierre Joye CC: "internals@lists.php.net" Thread-Topic: [PHP-DEV] Accessors v2 Patch Thread-Index: Acy4OjadBvFZYH6iTIC+0CF/aviwQwALIDKAAADGOsAACYqOgAAKTuDw//+wfgCAAFBb4A== Date: Mon, 12 Dec 2011 01:01:46 +0000 Message-ID: <9570D903A3BECE4092E924C2985CE4853995598C@MBX202.domain.local> References: <9570D903A3BECE4092E924C2985CE485399554D7@MBX202.domain.local> <7070130643313812382@unknownmsgid> <9570D903A3BECE4092E924C2985CE4853995589C@MBX202.domain.local> <9570D903A3BECE4092E924C2985CE48539955910@MBX202.domain.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.64.23] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] Accessors v2 Patch From: cpriest@zerocue.com (Clint M Priest) To be complete I should probably add something to the reflection system as = well. At present the getters/setters would show up as functions. What would be preferable? 1) Show up as regular functions and let users fend for themselves? 2) Hide from getMethods() and: 2.1) Provide getAccessors() - Probably returning a new ReflectionProperty= Accessor class? 2.2) Provide getGetters(), getSetters() 3) Modify ReflectionProperty to include hasGetter() and hasSetter() Comments? -----Original Message----- From: Pierre Joye [mailto:pierre.php@gmail.com]=20 Sent: Sunday, December 11, 2011 6:47 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest wrote= : > There are already two tests against private read and private write, shoul= d I add two for protected as well? Cheers, --=20 Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org