Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56871 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8919 invoked from network); 11 Dec 2011 19:41:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Dec 2011 19:41:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=will.fitch@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=will.fitch@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender) X-PHP-List-Original-Sender: will.fitch@gmail.com X-Host-Fingerprint: 209.85.214.42 mail-bw0-f42.google.com Received: from [209.85.214.42] ([209.85.214.42:57629] helo=mail-bw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F3/83-21075-35705EE4 for ; Sun, 11 Dec 2011 14:41:08 -0500 Received: by bkbzx1 with SMTP id zx1so2044827bkb.29 for ; Sun, 11 Dec 2011 11:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=references:from:in-reply-to:mime-version:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=+lZZCSkkcBx8gvJi4g1hDG8aof6eqgMnhrHlPxVKlXA=; b=qdqg+e2mwRvkEAqx2WBuyCg+dNKuNIxGaSVc6WqVdGa+XmRZ0ZNMpC2G9085kpnNe0 k9WxHeR4Mbb5KA/8YEgZpfyEy6QKv7OkprpQoUMIcQ8+FTJwlY88Jm9VbWiKNkUQ8Tuj elSbtWzPCfzM2T1Xo9R4awma7nFSzjII6e9f8= Received: by 10.205.130.146 with SMTP id hm18mr7886193bkc.19.1323632464620; Sun, 11 Dec 2011 11:41:04 -0800 (PST) References: <9570D903A3BECE4092E924C2985CE485399554D7@MBX202.domain.local> In-Reply-To: <9570D903A3BECE4092E924C2985CE485399554D7@MBX202.domain.local> Mime-Version: 1.0 (1.0) Date: Sun, 11 Dec 2011 14:40:59 -0500 Message-ID: <7070130643313812382@unknownmsgid> To: Clint M Priest Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Accessors v2 Patch From: will.fitch@gmail.com (Will Fitch) Much better implementation. As for the failed tests, I would double check and make sure you don't have any stray debug statements (e.g. printf). Sent from my iPhone On Dec 11, 2011, at 2:27 PM, Clint M Priest wrote: > https://bugs.php.net/patch-display.php?bug_id=3D49526&patch=3Daccessor_v2= .diff&revision=3Dlatest > > I rewrote part of how it handles the job due to abysmal performance of ve= rsion 1. This one is near the same performance as without the code changes= using __get() and is actually faster in some cases (public getter). > > I also checked all the tests and fixed the issues I found related. > > There is however some strange behavior that I do not understand. For som= e reason if I run all of the tests, 100+ or so will fail. If I have the te= st script write those failed tests to a file and just run those tests, all = but four work fine. It appears to be something to do with line endings, in= other cases the output does not match expected because of the addition of = 'unicode' to the output. I've no idea what's going on here but after 3 day= s of mucking around, I can't find a solution as to why this is occurring. > > These failures do not occur on a fresh checkout but nothing I've changed = should be causing any of the issues, just no idea here, any help would be a= ppreciated. > > Felipe: I could not find any segmentation fault tests from before when yo= u posted, nor now. Are you still seeing segmentation faults? > > Thoughts? > > -Clint >