Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56870 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6512 invoked from network); 11 Dec 2011 19:26:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Dec 2011 19:26:31 -0000 Authentication-Results: pb1.pair.com header.from=cpriest@zerocue.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=cpriest@zerocue.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zerocue.com designates 74.115.204.40 as permitted sender) X-PHP-List-Original-Sender: cpriest@zerocue.com X-Host-Fingerprint: 74.115.204.40 relay-hub204.domainlocalhost.com Received: from [74.115.204.40] ([74.115.204.40:5163] helo=relay-hub204.domainlocalhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DC/03-21075-4E305EE4 for ; Sun, 11 Dec 2011 14:26:30 -0500 Received: from MBX202.domain.local ([169.254.2.249]) by HUB204.domain.local ([74.115.204.40]) with mapi id 14.01.0289.001; Sun, 11 Dec 2011 14:26:25 -0500 To: "internals@lists.php.net" Thread-Topic: Accessors v2 Patch Thread-Index: Acy4OjadBvFZYH6iTIC+0CF/aviwQw== Date: Sun, 11 Dec 2011 19:26:25 +0000 Message-ID: <9570D903A3BECE4092E924C2985CE485399554D7@MBX202.domain.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.64.23] Content-Type: multipart/alternative; boundary="_000_9570D903A3BECE4092E924C2985CE485399554D7MBX202domainloc_" MIME-Version: 1.0 Subject: Accessors v2 Patch From: cpriest@zerocue.com (Clint M Priest) --_000_9570D903A3BECE4092E924C2985CE485399554D7MBX202domainloc_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable https://bugs.php.net/patch-display.php?bug_id=3D49526&patch=3Daccessor_v2.d= iff&revision=3Dlatest I rewrote part of how it handles the job due to abysmal performance of vers= ion 1. This one is near the same performance as without the code changes u= sing __get() and is actually faster in some cases (public getter). I also checked all the tests and fixed the issues I found related. There is however some strange behavior that I do not understand. For some = reason if I run all of the tests, 100+ or so will fail. If I have the test= script write those failed tests to a file and just run those tests, all bu= t four work fine. It appears to be something to do with line endings, in o= ther cases the output does not match expected because of the addition of 'u= nicode' to the output. I've no idea what's going on here but after 3 days = of mucking around, I can't find a solution as to why this is occurring. These failures do not occur on a fresh checkout but nothing I've changed sh= ould be causing any of the issues, just no idea here, any help would be app= reciated. Felipe: I could not find any segmentation fault tests from before when you = posted, nor now. Are you still seeing segmentation faults? Thoughts? -Clint --_000_9570D903A3BECE4092E924C2985CE485399554D7MBX202domainloc_--