Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56836
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mindplay.dk from 209.85.161.170 cause and error)
MIME-Version: 1.0
In-Reply-To: <34B6F836-CC50-4470-AD5F-C6F8C471FC65@gmail.com>
References: <CADqTB_jQoGwqLbSMRUJR97XKSQu+KB3awvudjVGmoDB1gZLgsQ@mail.gmail.com>
	<9570D903A3BECE4092E924C2985CE4853994C39F@MBX202.domain.local>
	<b4a2362c6c5ffd4efbca8f8e907054c3@mohiva.com>
	<CADqTB_i3q6Kmd3LNnd5srkO1-4P6Ak9UtAGekVPhVYP2sfZFfA@mail.gmail.com>
	<34B6F836-CC50-4470-AD5F-C6F8C471FC65@gmail.com>
Date: Wed, 7 Dec 2011 12:50:14 -0500
Message-ID: <CADqTB_hguOHTQC5VK+yVgKR3gcL9vG8e8Jwtvu00y27FJE5hWw@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=f46d0444eda119b52204b3842ffe
Subject: Re: [PHP-DEV] Patch: getters/setters syntax Implementation
From: rasmus@mindplay.dk (Rasmus Schultz)

--f46d0444eda119b52204b3842ffe
Content-Type: text/plain; charset=ISO-8859-1

> if we're attempting to get around __set/get, let's not replace them with
more method implementations

I don't understand this argument. Accessors are methods - making them look
like something else won't change that fact.

In C#, type-hinted properties with automatic getters/setters actually
compile down to two method implementations, while implemented
getters/settings do the same, substituting "value" for whatever is required
to access the auto-implemented backing field.


On Tue, Dec 6, 2011 at 9:26 AM, Will Fitch <will.fitch@gmail.com> wrote:

>
> On Dec 6, 2011, at 8:58 AM, Rasmus Schultz wrote:
>
> > I agree with all of those points - the extra indentation looks messy, and
> > yes, type hints are important. It does fit better with PHP in general.
> >
> > It would be nice to also have support for automatic backing fields in
> > addition though - so something simple like this:
> >
> > class BlogPost
> > {
> >    private $_author;
> >
> >    public get author()
> >    {
> >        return $this->_author;
> >    }
> >
> >    public set author(Person $value)
> >    {
> >        $this->_author = $value;
> >    }
> > }
>
> I don't like this approach.  All efforts (which I'm currently part of) to
> implement type hinting return values will be compromised.  If you want to
> implement accessors, keep them within a syntax that makes sense.
>  Personally, I support the C# style as much as possible.  Methods are
> already overused for purposes they shouldn't be, so if we're attempting to
> get around __set/get, let's not replace them with more method
> implementations.
>
>

--f46d0444eda119b52204b3842ffe--