Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5678 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 15745 invoked by uid 1010); 23 Nov 2003 12:56:24 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 15671 invoked from network); 23 Nov 2003 12:56:23 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 23 Nov 2003 12:56:23 -0000 Received: (qmail 21798 invoked from network); 23 Nov 2003 12:56:21 -0000 Received: from localhost (HELO andi-laptop.zend.com) (127.0.0.1) by localhost with SMTP; 23 Nov 2003 12:56:21 -0000 Message-ID: <5.1.0.14.2.20031123145521.03188410@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Sun, 23 Nov 2003 14:56:20 +0200 To: Timm Friebe Cc: internals@lists.php.net In-Reply-To: <1069366149.302.6.camel@localhost> References: <5.1.0.14.2.20031120114209.0501bb18@127.0.0.1> <5.1.0.14.2.20031120114209.0501bb18@127.0.0.1> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Using do_alloca() instead of emalloc() From: andi@zend.com (Andi Gutmans) Commited thanks. Marcus, what we meant was that you shouldn't use do_alloca() in the engine except for in the cases I mentioned, and possibly cases where the allocations would be quite large. In the case of reflection API the allocations are small *and* the function returns right away, thus not keeping stuff on the stack for too long. Andi At 11:09 PM 11/20/2003 +0100, Timm Friebe wrote: >On Thu, 2003-11-20 at 10:48, Andi Gutmans wrote: > > Hey, > > > > I've been taking a look at the __autoload problem. During that time I saw > > that lots of places in the code (especially reflection API) use > > zend_str_tolower_dup(). >[...] > >Here's a patch for zend_reflection_api.c which uses do_alloca / >free_alloca in all relevant places. > >- Timm