Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56779
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain analysisandsolutions.com from 166.84.1.89 cause and error)
Date: Mon, 5 Dec 2011 09:59:50 -0500
To: Alan Knowles <alan@akbkhome.com>
Cc: internals@lists.php.net
Message-ID: <20111205145950.GA2331@panix.com>
References: <4EDA4989.2010702@akbkhome.com>
 <4EDB6DB0.2050909@akbkhome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4EDB6DB0.2050909@akbkhome.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: Re: [PHP-DEV] Fixing string offsets  of strings.
From: danielc@analysisandsolutions.com (Daniel Convissor)

Hi Alan:

> https://bugs.php.net/patch-display.php?bug=60362&patch=fix_disabling_bad_string_offsets&revision=1323002696

Thanks so much for the patch.  Looking at the source I noticed some
small things (care to build a bike shed with me? :).

Many of the test EXPECT's have %d changed to hard coded line numbers and
others have %s changed to hard coded file names.  In some of them,
that's all that changed.  I assume that will be cleaned up before
committing.

There are some extraneous whitespace changes in the source.

I tried to apply the patch to 54 and trunk via "patch < bug.diff"
(which usually works fine) and all hunks failled.  Not sure what I'm
doing wrong.

Thanks,

--Dan

-- 
 T H E   A N A L Y S I S   A N D   S O L U T I O N S   C O M P A N Y
            data intensive web and database programming
                http://www.AnalysisAndSolutions.com/
 4015 7th Ave #4, Brooklyn NY 11232  v: 718-854-0335 f: 718-854-0409