Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5677 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89913 invoked by uid 1010); 23 Nov 2003 12:34:27 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 89877 invoked from network); 23 Nov 2003 12:34:26 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 23 Nov 2003 12:34:26 -0000 Received: (qmail 20048 invoked from network); 23 Nov 2003 12:34:23 -0000 Received: from localhost (HELO andi-laptop.zend.com) (127.0.0.1) by localhost with SMTP; 23 Nov 2003 12:34:23 -0000 Message-ID: <5.1.0.14.2.20031123143325.02b2b9d8@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Sun, 23 Nov 2003 14:34:04 +0200 To: Cristiano Duarte ,internals@lists.php.net In-Reply-To: <20031123004031.32362.qmail@pb1.pair.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] [PATCH] Streams "file://" bug From: andi@zend.com (Andi Gutmans) References: <20031123004031.32362.qmail@pb1.pair.com> At 10:40 PM 11/22/2003 -0200, Cristiano Duarte wrote: >Hi all, > >The current implementation of file:// support under main/streams/strems.c >has a little bug. >Maybe it's my gcc 3.2.2 compiler... I don't know... >Anyway, the attached patch fixes it. > >Best Regards, > >Cristiano Duarte > > >? php-src/ZendEngine1 >Index: php-src/main/streams/streams.c >=================================================================== >RCS file: /repository/php-src/main/streams/streams.c,v >retrieving revision 1.39 >diff -u -r1.39 streams.c >--- php-src/main/streams/streams.c 3 Nov 2003 14:12:46 -0000 1.39 >+++ php-src/main/streams/streams.c 23 Nov 2003 00:31:08 -0000 >@@ -1433,9 +1433,9 @@ > #ifdef PHP_WIN32 > if (*(*path_for_open + 1) != ':') > #endif >- *path_for_open--; >+ --*path_for_open; > } >- >+ This should be changed to (*path_for_open)++ Andi