Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56764
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <9570D903A3BECE4092E924C2985CE48539946A34@MBX201.domain.local>
References: <9570D903A3BECE4092E924C2985CE485399460CA@MBX201.domain.local>
 <CAEZPtU7LTYJv_kXesO=MtdhRqxm1uKyoc6h2agQ8Qrv+R86=sA@mail.gmail.com> <9570D903A3BECE4092E924C2985CE48539946A34@MBX201.domain.local>
Date: Sun, 4 Dec 2011 13:05:21 -0200
Message-ID: <CA+5g0SJNN7YA9Svs2WT+wMpPeXa_jf0jgmpg6Po6hrwSFcOW8A@mail.gmail.com>
To: Clint M Priest <cpriest@zerocue.com>
Cc: Pierre Joye <pierre.php@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Patch: getters/setters syntax Implementation
From: felipensp@gmail.com (Felipe Pena)

Hi,

2011/12/4 Clint M Priest <cpriest@zerocue.com>:
> Updated patch w/o white-space: http://www.clintpriest.com/patches/accesso=
rs_v1.patch
>
> In the end it is a relatively simple patch. =C2=A0The new syntax effectiv=
ely creates internal functions on the object and the system looks for those=
 functions and calls them at the appropriate time.
>
> Example:
> class z {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0public $Hours {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0public get { return $this->_Hours; }
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0protected set { $this->_Hours =3D $value; }
> =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> }
>
> Defines:
> $o->__getHours();
> $o->__setHours($value);
>
> Standard __get()/__set() functionality checks for the more specifically d=
efined function name and calls them. =C2=A0I thought this would make the mo=
st sense since it would allow us to leverage the existing inheritance funct=
ionality. =C2=A0This comes out with respect to interfaces and traits in tha=
t only errors had to be changed (for clarity) on interfaces and no changes =
to traits were necessary to support the new functionality.
>
> For the automatic get/set functionality, I essentially built the function=
 body myself within zend_do_end_accessor_declaration(). =C2=A0One point of =
contention here is that internally it defines a __$Hours property which wou=
ld be accessible from various points. =C2=A0I believe the standard C# get/s=
et does not allow any access to the underlying data storage. =C2=A0In order=
 to accomplish that there would need to be some non-standard storage or a s=
uper-private level or something. =C2=A0I did not explore that possibility a=
s of yet.
>
> I did add a couple of convenience functions that may already be available=
 in some other form I was not aware of, such as strcatalloc or MAKE_ZNODE()=
.
>
> --Clint
>
> -----Original Message-----
> From: Pierre Joye [mailto:pierre.php@gmail.com]
> Sent: Sunday, December 04, 2011 4:50 AM
> To: Clint M Priest
> Cc: internals@lists.php.net
> Subject: Re: [PHP-DEV] Patch: getters/setters syntax Implementation
>
> hi Clint!
>
>
> Thanks for your work so far!
>
> On Sun, Dec 4, 2011 at 1:33 AM, Clint M Priest <cpriest@zerocue.com> wrot=
e:
>
>> What are the next steps to get this added to some future release?
>
> Let discuss the =C2=A0implementation and how it works, then you can move =
to the voting phase. There is no need to hurry as the next release where th=
is patch could go in is next year.
>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

I've fixed the zend_compile.c and zend_object_handlers.c to build with
--enable-maintainer-zts. (some TSRMLS_CC missing and TSRMLS_DC usage
instead of TSRMLS_CC)
Other thing I have noticed that you have not followed our coding
standards about brackets and comments (we don't use the C++ style
one). And about the comments looks as the patch isn't finished or you
just forgot the remove them?

http://dpaste.com/665851/plain/

--=20
Regards,
Felipe Pena