Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56702 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98736 invoked from network); 1 Dec 2011 11:08:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Dec 2011 11:08:12 -0000 Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.160.170 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.160.170 mail-gy0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:34289] helo=mail-gy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 74/D3-10027-91067DE4 for ; Thu, 01 Dec 2011 06:08:10 -0500 Received: by ghbg16 with SMTP id g16so1963493ghb.29 for ; Thu, 01 Dec 2011 03:08:07 -0800 (PST) Received: by 10.50.17.168 with SMTP id p8mr7520347igd.20.1322737687231; Thu, 01 Dec 2011 03:08:07 -0800 (PST) Received: from [192.168.200.5] (c-50-131-44-225.hsd1.ca.comcast.net. [50.131.44.225]) by mx.google.com with ESMTPS id eb23sm20130309ibb.2.2011.12.01.03.08.04 (version=SSLv3 cipher=OTHER); Thu, 01 Dec 2011 03:08:05 -0800 (PST) Message-ID: <4ED76013.50601@lerdorf.com> Date: Thu, 01 Dec 2011 03:08:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Yasuo Ohgaki CC: internals@lists.php.net References: <4EBDC283.3040700@yahoo.co.jp> <4ED727FB.7030001@uw.no> In-Reply-To: X-Enigmail-Version: 1.4a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Strict session? From: rasmus@lerdorf.com (Rasmus Lerdorf) On 12/01/2011 02:38 AM, Yasuo Ohgaki wrote: > Hi Daniel, > > 2011/12/1 Daniel K. : >> Yasuo Ohgaki wrote: >>> >>> I've made the patch for trunk. I checked by using session module >>> tests using valgrind. >>> >>> https://gist.github.com/1379668 >> >> >> As a general comment there seems to be lots of extra white space in the >> 'empty' lines of the patch. > > Spaces are left by my emacs. > I don't think there are many lines with extra spaces, but I'll check. Please just tell your diff to ignore whitespace when you create the patch. It is annoying to have to sift through extra irrelevant lines. -Rasmus