Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:5668 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98599 invoked by uid 1010); 22 Nov 2003 18:51:08 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 98575 invoked from network); 22 Nov 2003 18:51:08 -0000 Received: from unknown (HELO miranda.org) (209.58.150.153) by pb1.pair.com with SMTP; 22 Nov 2003 18:51:08 -0000 Received: (qmail 6737 invoked by uid 546); 22 Nov 2003 18:51:07 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 22 Nov 2003 18:51:07 -0000 Date: Sat, 22 Nov 2003 13:51:07 -0500 (EST) X-X-Sender: adam@miranda.org To: Rob Richards cc: internals@lists.php.net In-Reply-To: <027c01c3b105$44a93ac0$f7dea8c0@cyberware.local> Message-ID: References: <027c01c3b105$44a93ac0$f7dea8c0@cyberware.local> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] SimpleXML XPath Namespace Support From: adam@trachtenberg.com (Adam Maccabee Trachtenberg) On Sat, 22 Nov 2003, Rob Richards wrote: > The question I have is in simplexml_ce_register_ns. As nsmap has no specific > scope, shouldnt all the entries be registered in the xpath context, which > would then need to happen in simplexml_ce_xpath_search? That's why I create a new xmlXPathNewContext inside simplexml_ce_register_ns. + if (!sxe->xpath) { + sxe->xpath = xmlXPathNewContext((xmlDocPtr) sxe->document->ptr); + } This seemed easier than doing an xmlHashScan inside simplexml_ce_xpath_search and this way we only register each namespace once. -adam -- adam@trachtenberg.com