Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56667 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90646 invoked from network); 29 Nov 2011 01:03:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 29 Nov 2011 01:03:59 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.213.42 mail-yw0-f42.google.com Received: from [209.85.213.42] ([209.85.213.42:62589] helo=mail-yw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2C/46-50663-E7F24DE4 for ; Mon, 28 Nov 2011 20:03:59 -0500 Received: by ywt2 with SMTP id 2so5994270ywt.29 for ; Mon, 28 Nov 2011 17:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=yoNAiQzc1gdU2rlFOH0szCcTtKSlVCkSRd2Xti6bAMs=; b=uY+44wrI5eUC79AXtr3KtihE/BSwCTiA0bYOmHX9bFctlE3NLh+7nDps26vyFsxlVj yBC+mLpfRkz9oMEmTNL2RcGya6NQ9SHdjtC26NfUiEQw5tlqwxNKzyL33uTubG/SZIAf ctg43qhlBNbGZIT/tIShoOnHj9hc5A+IrWix4= Received: by 10.236.76.136 with SMTP id b8mr68586748yhe.9.1322528635253; Mon, 28 Nov 2011 17:03:55 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.100.127.18 with HTTP; Mon, 28 Nov 2011 17:03:14 -0800 (PST) In-Reply-To: References: Date: Tue, 29 Nov 2011 10:03:14 +0900 X-Google-Sender-Auth: VUh4EC6UZ6c39yhQnm_Qd_qAir0 Message-ID: To: Karoly Negyesi Cc: internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] session.cache_limiter empty string? From: yohgaki@ohgaki.net (Yasuo Ohgaki) 2011/11/29 Yasuo Ohgaki : > Hi Karoly, > > 2011/10/12 Karoly Negyesi : >> Setting session.cache_limiter to an empty string doesn't send headers. >> Is this just an artefact of if (!strcasecmp(lim->name, >> PS(cache_limiter))) not matching the empty string or does if >> (PS(cache_limiter)[0] == '\0') return 0; deliberately stop it? >> >> Ie. what should I add to the documentation for people who don't want >> PHP to send anything? > > If I remember correctly, old doc was referred as "none". Any invalid > cache limiter name will be ignored, though. > > It may be good idea to raise notice error for invalid limiter name and > introduce "none" limiter. > > Any comments? > Hi Karoly, Failing silently in case of typo is not good. Could you file feature request to bugs.php.net? I'll make patch for trunk and commit it unless there is objection. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net