Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56649
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1111281343180.15415@whisky.home.derickrethans.nl>
References: <alpine.DEB.2.02.1111281300580.15415@whisky.home.derickrethans.nl>
	<CAH-PCH5jFaw4Y9S78MoFSbC66vD1ka5vwKc-dBE7-GkvmkDtdg@mail.gmail.com>
	<alpine.DEB.2.02.1111281334070.15415@whisky.home.derickrethans.nl>
	<CAKUjMCXdDaaT5f5UbgW0DYA-uySuNAH3n1qymCWCMWiO7KjLUA@mail.gmail.com>
	<alpine.DEB.2.02.1111281343180.15415@whisky.home.derickrethans.nl>
Date: Mon, 28 Nov 2011 15:18:40 +0100
Message-ID: <CAH-PCH7qwUVibB5P+Gd4EyicgWtHToM2PEjy7zZiSW0V=btHpA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Richard Quadling <rquadling@gmail.com>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=0016e64082dcf5f5bd04b2cc2d77
Subject: Re: [PHP-DEV] run-tests.php and dynamic extension dependencies
From: tyra3l@gmail.com (Ferenc Kovacs)

--0016e64082dcf5f5bd04b2cc2d77
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 28, 2011 at 2:44 PM, Derick Rethans <derick@php.net> wrote:

> On Mon, 28 Nov 2011, Richard Quadling wrote:
>
> > On 28 November 2011 13:36, Derick Rethans <derick@php.net> wrote:
> > > On Mon, 28 Nov 2011, Ferenc Kovacs wrote:
> > >
> > >> On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans <derick@php.net>
> wrote:
> > >>
> > >> > I'm currently writing a shared extension thta depends on another
> > >> > shared extension (igbinary). "make test" doesn't handle this at th=
e
> > >> > moment, because it removes every extension=3D line from it's tempo=
rary
> > >> > php.ini. This means that the dependent extension (igbinary) now
> > >> > isn't loaded, which means my extension doesn't load either and
> > >> > obviously all the tests fail.
> > >> >
> > >> > I've attached a patch that adds a new --EXTENSIONS-- section to th=
e
> > >> > PHPT format. The run-tests.php script makes sure that all extensio=
ns
> > >> > in that last are added to the PHP command with -dextension=3D... ,=
 but
> > >> > only if they're not build in (or already loaded in some other way)=
.
> > >> >
> > >> > The patch is simple, and it doesn't touch any other section or
> > >> > functionality so I'm suggesting to commit it to PHP 5.3/5.4 and
> > >> > trunk some time soon.
> > >>
> > >> wouldn't  --INI-- + extension do the same?
> > >
> > > No, as the run-tests.php framework changes "extension_dir" to
> > > "./modules/". It would also cause issues if you try to load an
> extension
> > > that is built-in. And it's not portable because not on every platform
> > > the extension name =3D extension.so
> >
> > Can you use PHP_SHLIB_SUFFIX?
>
> I am using that in my patch, but obviously that doesn't work with
> extension=3D on the command line, which is how run-tests.php passes in
> arguments from --INI--.
>
> derick@whisky:~$ php -dextension=3Digbinary.PHP_SHLIB_SUFFIX
> PHP Warning:  PHP Startup: Unable to load dynamic library
> '/usr/local/php/5.3dev/lib/php/extensions/debug-non-zts-20090626/igbinary=
.PHP_SHLIB_SUFFIX'
> -
> /usr/local/php/5.3dev/lib/php/extensions/debug-non-zts-20090626/igbinary.=
PHP_SHLIB_SUFFIX:
> cannot open shared object file: No such file or directory in Unknown on
> line 0


thanks for the answer, in this case I think this would be a worthwhile
improvement.

+ foreach ($extensions as $req_ext) {
+ $loaded =3D `$php -n -r 'echo (int) extension_loaded("$req_ext");'`;
+ if ($loaded =3D=3D '0') {

it would be more efficient to get all the loaded modules at
once(get_loaded_extensions or php -m)

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--0016e64082dcf5f5bd04b2cc2d77--