Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56645 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 4271 invoked from network); 28 Nov 2011 13:36:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Nov 2011 13:36:30 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:47203] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8F/02-21284-D5E83DE4 for ; Mon, 28 Nov 2011 08:36:30 -0500 Received: from localhost (xdebug.org [127.0.0.1]) by xdebug.org (Postfix) with ESMTPS id DE1F4DE13E; Mon, 28 Nov 2011 13:36:26 +0000 (GMT) Date: Mon, 28 Nov 2011 13:36:26 +0000 (GMT) X-X-Sender: derick@whisky.home.derickrethans.nl To: Ferenc Kovacs cc: PHP Developers Mailing List In-Reply-To: Message-ID: References: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] run-tests.php and dynamic extension dependencies From: derick@php.net (Derick Rethans) On Mon, 28 Nov 2011, Ferenc Kovacs wrote: > On Mon, Nov 28, 2011 at 2:11 PM, Derick Rethans wrote: > > > I'm currently writing a shared extension thta depends on another > > shared extension (igbinary). "make test" doesn't handle this at the > > moment, because it removes every extension= line from it's temporary > > php.ini. This means that the dependent extension (igbinary) now > > isn't loaded, which means my extension doesn't load either and > > obviously all the tests fail. > > > > I've attached a patch that adds a new --EXTENSIONS-- section to the > > PHPT format. The run-tests.php script makes sure that all extensions > > in that last are added to the PHP command with -dextension=... , but > > only if they're not build in (or already loaded in some other way). > > > > The patch is simple, and it doesn't touch any other section or > > functionality so I'm suggesting to commit it to PHP 5.3/5.4 and > > trunk some time soon. > > wouldn't --INI-- + extension do the same? No, as the run-tests.php framework changes "extension_dir" to "./modules/". It would also cause issues if you try to load an extension that is built-in. And it's not portable because not on every platform the extension name = extension.so cheers, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug