Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56597
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <4ECEBBB8.90604@lerdorf.com>
References: <20111123015008.GA12933@panix.com> <CAKUjMCWpv98-+VfxkSEjCgRDXJ5KXZaGCEA=0Q=h0kvXEtuGHg@mail.gmail.com>
 <CAGa2bXYARXzPXA5FS8q2ycmpULx9Y2BTVgdkcQireso1iUVN9Q@mail.gmail.com>
 <CAGa2bXa6xxz8P9XRvtag61A76Lrk99iQM2wrRa+QD+BkQukgLQ@mail.gmail.com> <4ECEBBB8.90604@lerdorf.com>
Date: Fri, 25 Nov 2011 06:53:42 +0900
Message-ID: <CAGa2bXbaUnpAwnV8Ypme5sdaBSPZ_S-m=cv2Mr4kB7_Y5NYBUg@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: RQuadling@gmail.com, Daniel Convissor <danielc@analysisandsolutions.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

2011/11/25 Rasmus Lerdorf <rasmus@lerdorf.com>:
> On 11/24/2011 01:44 PM, Yasuo Ohgaki wrote:
>> Hi all,
>>
>> I should think twice before seding mail. "abc" as array index is
>> converted to 0 since it's not a integer. So with current code is
>> behave consistently with regards to string to long conversion.
>>
>> However,
>>
>> PHP 5.3
>> php -r '$s =3D "abc"; var_dump($s[0]["bar"]);'
>> PHP Fatal error: =A0Cannot use string offset as an array in Command line
>> code on line 1
>>
>> PHP 5.4
>> ./php -r '$s =3D "abc"; var_dump($s[0]["bar"]);'
>> string(1) "a"
>>
>> Isn't it better to raise notice for accessing string by string index?
>> There is no use to allowing string index access to strings. I think
>> raising notice is feasible. Isn't it?
>
> String index access is still required since they are often numeric
> strings. We could add a notice for non-numeric strings, but the check
> would slow things down a bit.

How about enable notice only for PHP 5.4?

Programmer should check vars to see if it's an array, but finding the
cause of misbehavior without errors is pain for users.

I don't think we have to remove this feature, but it would be nice to
raise notice error for a while.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net