Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56596
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4ECEBBB8.90604@lerdorf.com>
References: <20111123015008.GA12933@panix.com>
	<CAKUjMCWpv98-+VfxkSEjCgRDXJ5KXZaGCEA=0Q=h0kvXEtuGHg@mail.gmail.com>
	<CAGa2bXYARXzPXA5FS8q2ycmpULx9Y2BTVgdkcQireso1iUVN9Q@mail.gmail.com>
	<CAGa2bXa6xxz8P9XRvtag61A76Lrk99iQM2wrRa+QD+BkQukgLQ@mail.gmail.com>
	<4ECEBBB8.90604@lerdorf.com>
Date: Thu, 24 Nov 2011 22:52:42 +0100
Message-ID: <CAH-PCH6QWgh=EsAn6yvGKHYXZd3Q6f+=Rh3AF1+pZwkRM-+u+g@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>, RQuadling@gmail.com, 
	Daniel Convissor <danielc@analysisandsolutions.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=0016e64bff5a50e28d04b2820e29
Subject: Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values
From: tyra3l@gmail.com (Ferenc Kovacs)

--0016e64bff5a50e28d04b2820e29
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 24, 2011 at 10:48 PM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote=
:

> On 11/24/2011 01:44 PM, Yasuo Ohgaki wrote:
> > Hi all,
> >
> > I should think twice before seding mail. "abc" as array index is
> > converted to 0 since it's not a integer. So with current code is
> > behave consistently with regards to string to long conversion.
> >
> > However,
> >
> > PHP 5.3
> > php -r '$s =3D "abc"; var_dump($s[0]["bar"]);'
> > PHP Fatal error:  Cannot use string offset as an array in Command line
> > code on line 1
> >
> > PHP 5.4
> > ./php -r '$s =3D "abc"; var_dump($s[0]["bar"]);'
> > string(1) "a"
> >
> > Isn't it better to raise notice for accessing string by string index?
> > There is no use to allowing string index access to strings. I think
> > raising notice is feasible. Isn't it?
>
> String index access is still required since they are often numeric
> strings. We could add a notice for non-numeric strings, but the check
> would slow things down a bit.


yeah, as I mentioned before:
"The other improvement (related but not introduced in this change) that I
suggested was that we could also trigger a notice when a "non-applicable"
string offset is passed(defining non-applicable is a little bit hard,
because of the current type-juggling rules, we have to allow $string["1"],
because '1" can come from a database, or get/post, where it would be a
string, not an int, but if we go with the current type juggling,
$string["2_foo_3"] would also be converted to $string[2], which isn't
really intended imo. ."

I would vote for allowing only numbers in the string index/offset: [0-9]+

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--0016e64bff5a50e28d04b2820e29--