Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56565
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAET_qdMyTQ+M7yeQNj9LHxdTYnydMJcL2QDmdpv5Lag+Dcttbw@mail.gmail.com>
References: <20111123015008.GA12933@panix.com>
	<CACQesk6UuGUgyJz3hsGVE0crJx3GCkjTTpLb4xNGTm1goLzO8Q@mail.gmail.com>
	<20111123023108.GA172@panix.com>
	<CACQesk5kj=4kzvTDiLL1oOLBXZrn4WdUcLXdbyMLTa=OdhGTcw@mail.gmail.com>
	<4ECCB549.904@lsces.co.uk>
	<4ECCBC56.3050602@sugarcrm.com>
	<20111123141408.GA11940@panix.com>
	<4ECD40E2.1000601@sugarcrm.com>
	<CAH-PCH6f30p6AfNT9z=wVPURo4ko08sMTwHiEQsdpauN-cYtwQ@mail.gmail.com>
	<4ECD48AD.1020207@sugarcrm.com>
	<4ECD91F4.5040303@gmail.com>
	<4ECD92FD.7040609@sugarcrm.com>
	<4ECD9998.4060203@lsces.co.uk>
	<4ECDA01B.5090606@sugarcrm.com>
	<CAET_qdMyTQ+M7yeQNj9LHxdTYnydMJcL2QDmdpv5Lag+Dcttbw@mail.gmail.com>
Date: Thu, 24 Nov 2011 11:40:09 +0100
Message-ID: <CAH-PCH47CCKOOG0q0gCafNoG2Lgvmpe-bCsD7CFa5ZKiYZkMHQ@mail.gmail.com>
To: devis@lucato.it
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, Lester Caine <lester@lsces.co.uk>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf303346551d210f04b278a94c
Subject: Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values
From: tyra3l@gmail.com (Ferenc Kovacs)

--20cf303346551d210f04b278a94c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 24, 2011 at 11:05 AM, <devis@lucato.it> wrote:

> On 24 November 2011 01:38, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> > Hi!
> >
> >> But neither is introducing a potential bomb of the kind that the 'date=
'
> >> saga
> >> created. The problem this change IS causing is likely to hit many live
> >> sites
> >
> > The claim that many live sites actually regularly use string multiple
> string
> > offsets to distinguish strings from arrays sounds implausible to me.
> >
>
>
> Hi,
>
> I hadn't the opportunity to install php 5.4 to test this, so I was
> wondering if someone could test how would this code behave ?
>
> ###########
> if (
> !isset( $widget_options['dashboard_incoming_links'] )
>  || !isset( $widget_options['dashboard_incoming_links']['home'] )
>  || $widget_options['dashboard_incoming_links']['home'] !=3D
> get_option('home') )
> ###########
>
> Is that correct saying that if the first condition is false the second
> will always be true ?
>
> Note: that's a piece of Wordpress
>
>
hi.

you can also test it http://codepad.viper-7.com/ if you don't want/can't
have a build from source.
What does get_option('home') return?
From a quick glance, I think that you are safe, except if you get a string
instead of an array(either for $widget_options
or $widget_options['dashboard_incoming_links']), and the first character of
that string is a slash and your get_option('home') returns a slash also.
in which case your code will behave as it would get a correct array
having $widget_options['dashboard_incoming_links']['home'] =3D '/'

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--20cf303346551d210f04b278a94c--