Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56533 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87809 invoked from network); 23 Nov 2011 19:48:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Nov 2011 19:48:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.160.170 mail-gy0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:55349] helo=mail-gy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4B/F6-47904-A0E4DCE4 for ; Wed, 23 Nov 2011 14:48:31 -0500 Received: by ghrr20 with SMTP id r20so1949273ghr.29 for ; Wed, 23 Nov 2011 11:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=XiOl9e7Ab45F+vt/7lMcgSANTjC/47I8tV2vDYPM7WM=; b=FVFeOSoZDNsvUIk5G/x1P4eFl8O7LIBPCQYNfVPGoe+Tt09cxX3iyU1lqzTdx8r9jU nEokBqWUlTPAtJkAaCwY8Yy8wdTlM0/jx4EXFv2O+QtmfxwcLFSJOafpDTbNMxhmu1Rg UovBmPhM3NTm9Ch7/fAUhZbkMAKXuTnrnvKAM= Received: by 10.236.192.233 with SMTP id i69mr37844287yhn.60.1322077702843; Wed, 23 Nov 2011 11:48:22 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.100.127.18 with HTTP; Wed, 23 Nov 2011 11:47:37 -0800 (PST) In-Reply-To: <4ECD4B50.6020005@sugarcrm.com> References: <4ECD4B50.6020005@sugarcrm.com> Date: Thu, 24 Nov 2011 04:47:37 +0900 X-Google-Sender-Auth: h6q_7XznALozbmix62XpBfwBqAI Message-ID: To: Stas Malyshev Cc: Pierre Joye , Rafael Kassner , "internals@lists.php.net" Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] pg_escape_literal(), pg_escape_identifier() patch From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Stats, 2011/11/24 Stas Malyshev : > Hi! > >> These escape functions are not mandatory, but these functions increase >> usability of PHP and pgsql module. >> >> Do you think it is ok to merge the patch to 5.4 branch? > > Unless there's a very compelling reason for that (i.e., security > implications, missing support for a widely used part of existing > functionality, etc.) I would prefer to wait till 5.4.1 with any additions. > So the question is does it have such compelling reason? These are optional features. It would be handy for some people. 5.4 is in RC, so holding it to next release sounds reasonable. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net