Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56517
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.49 as permitted sender)
MIME-Version: 1.0
Reply-To: RQuadling@GMail.com
In-Reply-To: <20111123153100.GB13420@panix.com>
References: <20111123015008.GA12933@panix.com> <CACQesk6UuGUgyJz3hsGVE0crJx3GCkjTTpLb4xNGTm1goLzO8Q@mail.gmail.com>
 <20111123023108.GA172@panix.com> <CACQesk5kj=4kzvTDiLL1oOLBXZrn4WdUcLXdbyMLTa=OdhGTcw@mail.gmail.com>
 <4ECCB549.904@lsces.co.uk> <4ECCBC56.3050602@sugarcrm.com>
 <20111123141408.GA11940@panix.com> <20111123153100.GB13420@panix.com>
Date: Wed, 23 Nov 2011 17:58:42 +0000
Message-ID: <CAKUjMCVkmd2+=K9n6XVMeKvMCaMwORQN-3phA2CqZVjXBChPSg@mail.gmail.com>
To: Daniel Convissor <danielc@analysisandsolutions.com>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values
From: rquadling@gmail.com (Richard Quadling)

On 23 November 2011 15:31, Daniel Convissor
<danielc@analysisandsolutions.com> wrote:
> Hi Again Folks:
>
> On Wed, Nov 23, 2011 at 09:14:09AM -0500, Daniel Convissor wrote:
>> $a =3D 'foo';
>> echo $a['blah'] . "\n";
>>
>> But that second one echos out "f". =C2=A0This is a huge WTF.
>
> Two things for the record on this front. =C2=A0First, i've been actively
> using PHP for, what, ten years or so, and have never run into this
> behavior before. =C2=A0Second, this behavior turns the following one line=
r:
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if (isset($arr['package']['attribs']['version'=
])) {
>
> Into this:
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if (is_array($arr)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& array_key_exist=
s('package', $arr)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& is_array($arr['=
package'])
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& array_key_exist=
s('attribs', $arr['package'])
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& is_array($arr['=
package']['attribs'])
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& array_key_exist=
s('version', $arr['package']['attribs'])
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&& !empty($arr['pa=
ckage']['attribs']['version']))
> =C2=A0 =C2=A0 =C2=A0 =C2=A0{

I agree with Daniel on this.


Just looking for any test relating to isset() to see what tests will now fa=
il.

Neither of the isset() tests ext/standard/tests/general_functions look
at arrays with associative indices.

The behaviour with regard to unavailable associative indices has no tests.

But using loose typing as a fallback for non existent keys seems
really really wrong.

Especially if the key is a constant. On what planet should ...

isset($arr['exists']['test_existance']) should become isset($arr['exists'][=
0])

That just seems really wrong and the work around is awful.
--=20
Richard Quadling
Twitter : EE : Zend : PHPDoc : Fantasy Shopper
@RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea=C2=A0:
fan.sh/6/370