Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56484
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 213.123.26.187 cause and error)
Message-ID: <4ECCB549.904@lsces.co.uk>
Date: Wed, 23 Nov 2011 08:56:41 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Firefox/7.0.1 SeaMonkey/2.4.1
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
References: <20111123015008.GA12933@panix.com> <CACQesk6UuGUgyJz3hsGVE0crJx3GCkjTTpLb4xNGTm1goLzO8Q@mail.gmail.com> <20111123023108.GA172@panix.com> <CACQesk5kj=4kzvTDiLL1oOLBXZrn4WdUcLXdbyMLTa=OdhGTcw@mail.gmail.com>
In-Reply-To: <CACQesk5kj=4kzvTDiLL1oOLBXZrn4WdUcLXdbyMLTa=OdhGTcw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have
 values
From: lester@lsces.co.uk (Lester Caine)

Etienne Kneuss wrote:
>>> AFAIK this is one of the change that was explicitly put in to make it
>>> >>  more consistent.
>> >
>> >  But now it breaks code in the wild.  I came across this due to an
>> >  isset() in PEAR now passing when it didn't before.
> PEAR is definitely doing some strange things:)  Is it checking indices
> of a variables without checking first if it's an array?
> Sounds like the comeback of "Please don't break bad code!" seen with is_a:)
>
> IMO it still makes sense to make that change for 5_4, makes everything
> less magic and more consistent.

I'm having a lot of trouble with working out WHAT is going on here at all.

https://bugs.php.net/bug.php?id=60362 as far as I can tell is using array and 
sub array elements? Strings don't come into the equation? So I check if I've 
populated the sub-array be seeing if a sub array element exists, such as would 
happen if I've populated the array in a previous scan through, but now I'm 
getting sub array elements caused by some conversion of the string making up the 
element above?

Now that this activity has been highlighted it may well explain why I'm getting 
problems with a section of code that is building a complex tree structure array 
from GEDCOM data strings ... since the code is not my own working out where 
things were breaking down was a problem I simply do not have time to 
investigate. It currently fails on PHP5.4 and it took some time to tidy the code 
on 5.3 ... and that still only runs with warnings switched off :(

So what is the current preferred method of checking if sub array elements have 
been created manually, rather than as 'less magic' string elements?

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk//
Firebird - http://www.firebirdsql.org/index.php