Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56482 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52749 invoked from network); 23 Nov 2011 07:03:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Nov 2011 07:03:32 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.163 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.163 smtp163.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.163] ([67.192.241.163:33731] helo=smtp163.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BB/C0-45113-2CA9CCE4 for ; Wed, 23 Nov 2011 02:03:31 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp26.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 4740D8032A; Wed, 23 Nov 2011 02:03:27 -0500 (EST) X-Virus-Scanned: OK Received: by smtp26.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 06878802DE; Wed, 23 Nov 2011 02:03:26 -0500 (EST) Message-ID: <4ECC9ABE.1010709@sugarcrm.com> Date: Tue, 22 Nov 2011 23:03:26 -0800 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: PHP Internals CC: Gustavo Lopes Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: intl IDNA patch (was: Re: [PECL-DEV] libidn2 extension for php) From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! First of all, I would like to politely ask everybody on the list to change subject if, well, subject of the discussion changes. I was totally under impression that this topic still discusses libidn2 extension in PECL and might miss discussion about intl IDNA patch if David didn't point it to me (thanks!). Let's use subjects for their intended purpose :) Now about the patch: 0. I consider it a bugfix, so I am OK with getting it in anytime it's ready. Thanks for making the quick patch, Gustavo! 1. I'm not sure I understand why we need two options fields. We already have one options field, won't that be enough? We can combine options and space them in a way that old ones work fine with new ones, can't we? And have default variant so one of them is always true (probably 2003). 2. I think optional by-ref parameter to receive IDNA-specific error codes is right. Generic intl error reporting is about reporting, well, generic errors and is not meant to have granularity enough to store whole UIDNAInfo stuff. 3. I'm not sure I understand the code in php_intl_bad_args() - it composes error message into the buff but then only sets it if msg != NULL. It doesn't check msg before using it in sprintf. Looks like something's missing there: I don't see how msg can be NULL there at all but if we check it, let's check it right :) Another place has the same code. 4. Also we'd want some tests with that ;) -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227