Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56466
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXaCQCRcOW_zKqzc5aiugKz77TTbZnUdt5k_QaWoU2yB7w@mail.gmail.com>
References: <CAGa2bXaCQCRcOW_zKqzc5aiugKz77TTbZnUdt5k_QaWoU2yB7w@mail.gmail.com>
Date: Tue, 22 Nov 2011 09:35:41 -0200
Message-ID: <CA+S5htPqvpadqMvn1pg8gSG0gtNjLrS56KhV2ZKbqLdD7gRCqA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] pg_escape_literal(), pg_escape_identifier() patch
From: kassner@gmail.com (Rafael Kassner)

Amazing!

I was in big troubles with multibyte escaping a couple years ago.
Nowadays, after a big ship of encoding problems (not only with db, but
navigator encoding, proxy caching and so on), I've ported everything
to UTF-8 (this included rewrite a 8 years old application). I guess
this is a good implementation, considering that many people still use
old PostgreSQL versions.

About pg_escape_identifier, fixes this an old problem when we use some
reserved column names, like "login"?

On Mon, Nov 21, 2011 at 8:41 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi all,
>
> I've posted pgsql patch that adds
> pg_escape_literal()/pg_escape_identifier() which escapes SQL literal
> and idetifier. (i.e. table names, filed names, etc)
>
> https://gist.github.com/1381181
>
> When I post a patch while ago, someone mentioned about that pgsql
> module own escape implementation may not be needed. I'm OK with both
> with/without pgsql own escape implementation. I ported escaped
> function that handles multibyte string correctly, in case of libpq
> does not have it. i.e. PostgreSQL 8.4 or less. As far as I know, older
> PostgreSQL (at least 8.0 >) handles literal/identifier escape
> correctly.
>
> It seems trunk is open for new feature. I'll commit the patch as is if
> there is no objection.
>
> Any comments?
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Atenciosamente,
Rafael Kassner