Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56454 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89422 invoked from network); 21 Nov 2011 09:27:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Nov 2011 09:27:33 -0000 Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:48921] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 22/82-06281-5891ACE4 for ; Mon, 21 Nov 2011 04:27:33 -0500 Received: from localhost (xdebug.org [127.0.0.1]) by xdebug.org (Postfix) with ESMTPS id 5BD87DE13E; Mon, 21 Nov 2011 09:27:30 +0000 (GMT) Date: Mon, 21 Nov 2011 09:27:30 +0000 (GMT) X-X-Sender: derick@whisky To: Stas Malyshev cc: PHP Internals In-Reply-To: <4ECA12FE.9000201@sugarcrm.com> Message-ID: References: <4EC9AC3D.6090602@sugarcrm.com> <4ECA12FE.9000201@sugarcrm.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] datetime status From: derick@php.net (Derick Rethans) On Mon, 21 Nov 2011, Stas Malyshev wrote: > > That is incorrect, not every timezone DST change is 60 minutes. > > The I would guess this code in do_adjust_timezone() also wrong: > > case TIMELIB_ZONETYPE_ABBR: { > timelib_sll tmp; > > tz->is_localtime = 1; > tmp = tz->z; > tmp -= tz->dst * 60; > tmp *= 60; > return tmp; > } > > Since it makes the same assumption? Maybe. It's not a huge problem and I think I might have shouted too soon. Perhaps ABBR types are only triggered for a specific hard coded list where the DST bit is always an hour. I'll need to check that! (Added to my list). Derick