Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56391
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
Sender: nicolas.grekas@gmail.com
In-Reply-To: <FC.D5.06569.4F226CE4@pb1.pair.com>
References: <CABBJUpft+eK6yF2cr1w=CuzzYUzubjDYJdhc08qnbDJnvw32ig@mail.gmail.com>
 <4EC025B4.2070009@sugarcrm.com> <A8.40.12248.970F0CE4@pb1.pair.com>
 <4EC17308.6030406@sugarcrm.com> <FC.D5.06569.4F226CE4@pb1.pair.com>
Date: Fri, 18 Nov 2011 12:46:05 +0100
Message-ID: <CAOWwgpkCaLfEmun9uPq2Fyz+rQXhZoK+km__-txnyt_APij_jA@mail.gmail.com>
To: Michael Wallner <mike@php.net>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=20cf303f6c5c01ea3604b200e3ae
Subject: Re: [PHP-DEV] function ob_gzhandler is missed in 5.4
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--20cf303f6c5c01ea3604b200e3ae
Content-Type: text/plain; charset=ISO-8859-1

Without a real ob_gzhandler function, replacing it with an alias as
currently in RC1 : what if someone then creates an ob_gzhandler function in
userland ? would ob_start('ob_gzhandler') use the userland function or
still the alias ? I think this is a second argument to make ob_gzhandler a
real function : least surprise.

Personally, I do use ob_gzhandler directly because it's the easiest way to
do chunked compressed encoding in userland.

This allows me to ask for compression as late as possible, because
registering an ob_start('ob_gzhandler'); may be too early for me. I do want
to choose to enable compression only when the very first byte is about to
be sent over the wire.

Hope it helps

Nicolas

<?php

function my_ob_handler($buffer, $mode)
{
// based on content-type,
// do some $buffer filtering
// and add some header()

if (/* content-type benefits compression based on some userland rules */)
{
  $buffer = ob_gzhandler($buffer, $mode); // benefits from gzip
negotiation, chunked compression and related headers

  if (PHP_OUTPUT_HANDLER_START & $mode)
  {
  // play/fix with Vary: header, as sent by ob_gzhandler or before
  }
}

return $buffer;
}

--20cf303f6c5c01ea3604b200e3ae--