Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56381 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10107 invoked from network); 18 Nov 2011 05:04:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Nov 2011 05:04:34 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.163 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.163 smtp163.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.163] ([67.192.241.163:34811] helo=smtp163.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 56/20-06569-067E5CE4 for ; Fri, 18 Nov 2011 00:04:33 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp16.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 2218840681; Fri, 18 Nov 2011 00:04:30 -0500 (EST) X-Virus-Scanned: OK Received: by smtp16.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id B749940334; Fri, 18 Nov 2011 00:04:29 -0500 (EST) Message-ID: <4EC5E75D.80801@sugarcrm.com> Date: Thu, 17 Nov 2011 21:04:29 -0800 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: =?ISO-8859-1?Q?David_Z=FClke?= CC: Matthew Weier O'Phinney , "internals@lists.php.net" References: <0DA562DA-2556-4179-8BB4-834313B6B9FB@bitextender.com> In-Reply-To: <0DA562DA-2556-4179-8BB4-834313B6B9FB@bitextender.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > First of all, ob_clean() and ob_end_clean() will raise the same > notice even in PHP 5.3. It seems inconsistent to me to treat these > three differently, so in that regard, PHP 5.4 is actually fixing > behavior (although arguably the other way to approach the problem is > to remove the notice from all three of them). I don't think ob_end_clean() should produce notices, otherwise it leads to needless boilerplate code like: if(ob_get_evel()>0) ob_end_clean(); while you could just write ob_end_clean() and be done with it. ob_clean() is trickier since it's supposed to leave buffer in place, but for functions that are supposed to remove the buffer warning doesn't add any value, only makes people write uglier code. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227