Newsgroups: php.internals,php.pecl.dev
Path: news.php.net
Xref: news.php.net php.internals:56349 php.pecl.dev:8873
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: Philip Olson <philip@roshambo.org>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, Felipe Pena <felipensp@gmail.com>,
 PHP Internals <internals@lists.php.net>, PECL Announce
 <pecl-dev@lists.php.net>
In-Reply-To: <8587F05B-1916-419E-AA95-D239EC77CAD3@roshambo.org>
References:
	 <CAH-PCH5odG590A3S9pa7af-VFaMKdg25nOnY7AyzwmqRfKLttQ@mail.gmail.com>
	 <CA+5g0SJcMpMeEMiXUTo_H=bkUz76NigUE4tiKpwHj3vTffyzOQ@mail.gmail.com>
	 <CAH-PCH5w3Nwe5nK+wzJowfdJrxiJK3MYitp4E+Ki9fNzqXdVng@mail.gmail.com>
	 <1321450474.29236.11.camel@guybrush>
	 <8587F05B-1916-419E-AA95-D239EC77CAD3@roshambo.org>
Content-Type: multipart/mixed; boundary="=-iSSD1f8E8qNlbyaDTor/"
Date: Wed, 16 Nov 2011 20:26:41 +0100
Message-ID: <1321471601.29236.58.camel@guybrush>
Mime-Version: 1.0
Subject: Re: [PHP-DEV] pecl sqlite
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

--=-iSSD1f8E8qNlbyaDTor/
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Wed, 2011-11-16 at 06:00 -0800, Philip Olson wrote:
> We need to make pecl/sqlite work with 5.4, as currently it does not. I 
> forget the details (and the related patch) but did work on one with
> Johannes many months ago. The last step (which failed) was to get 
> pdo_sqlite2 to work with the shared PECL variant, IIRC. Then, make a 
> release.
> 
> Moving something to PECL should require that the PECL extension work with
> the distribution that it was [re]moved from. Otherwise, it was not moved.
> 
> Johannes probably assumed I adjusted/committed the patch, and made a
> pecl/sqlite release, but he forgot that I forgot to do this, and I have
> since lost said patch and progress and most memories. Sorry :]

Looking at the patch from that time: The thing which was to be fixed was
enabling the sqlite2 PDO driver. For that the patch added an configure
option.

What we discussed, but not decide, was whether we'd force the PDO driver
on the user or not. If we force it on the user the user also needs to
have PDO loaded, even when not using the PDO API.

johannes


--=-iSSD1f8E8qNlbyaDTor/
Content-Disposition: attachment; filename="sqlite_pdo.diff"
Content-Type: text/x-patch; name="sqlite_pdo.diff"; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Index: config.m4
===================================================================
--- config.m4	(revision 313356)
+++ config.m4	(working copy)
@@ -9,8 +9,8 @@
 PHP_ARG_ENABLE(sqlite-utf8, whether to enable UTF-8 support in sqlite (default: ISO-8859-1),
 [  --enable-sqlite-utf8      SQLite: Enable UTF-8 support for SQLite], no, no)
 
+PHP_ARG_ENABLE(pdo-sqlite2, whether to aditionally enable pdo_sqlite2 driver. Depends on sqlite, [  --enable-pdo-sqlite2  SQLite: whether to aditionally enable pdo_sqlite2 driver. Depends on sqlite], no, no)
 
-
 dnl
 dnl PHP_PROG_LEMON
 dnl
@@ -46,7 +46,7 @@
 
 
 if test "$PHP_SQLITE" != "no"; then
-  if test "$PHP_PDO" != "no"; then
+  if test "$PHP_PDO_SQLITE2" != "no"; then
     PHP_CHECK_PDO_INCLUDES([], [AC_MSG_WARN([Cannot find php_pdo_driver.h.])])
     if test -n "$pdo_inc_path"; then
       AC_DEFINE([PHP_SQLITE2_HAVE_PDO], [1], [Have PDO])

--=-iSSD1f8E8qNlbyaDTor/--