Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56308
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: Antoine Delignat-Lavaud <antoine.delignat-lavaud@ens-cachan.fr>
Cc: internals@lists.php.net
In-Reply-To: <1321150216.1766.6.camel@guybrush>
References: <4EBF1F70.5090700@ens-cachan.fr>
	 <1321150216.1766.6.camel@guybrush>
Content-Type: text/plain; charset="UTF-8"
Date: Sun, 13 Nov 2011 12:22:36 +0100
Message-ID: <1321183356.2528.16.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Making in_array a language operator
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Sun, 2011-11-13 at 03:10 +0100, Johannes Schlüter wrote:
> For 5.5 I also have doubts whether it's worth the additional keyword and
> opcode. Yes it will, most likely, but this is an extension to the
> grammar ...

I meanwhile did a quick check on google codesearch. I found a few cases
where "in" was used as property or method name. Notable cases there are
zeta components and doctrine2 which this patch would break.

Two more comments I wanted to make:

Your using is_equal_function, this does a == comparison. People will
stumble over $a = 0; $a in ["a", "b", "c", "it's easy as one two
three"]; which will be true. This is the consistent and correct
behaviour for the language but people will ask for a "strict" mode.

For converting functions into opcodes - aren't there more relevant
candidates? strlen() or such come to mind. And no, I won't make them
constructs either.

johannes