Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56278
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4EBC6986.3090709@lerdorf.com>
References: <4EBC6986.3090709@lerdorf.com>
Date: Fri, 11 Nov 2011 14:45:32 +0000
Message-ID: <CA+p1TcaJ3d_-iYGmHcFTurBZrY4qEiUmihvENpBWjaS1F-ki_g@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf307cffb8b192f304b176924c
Subject: Re: Hash problems in session-oo code
From: arraypad@gmail.com (Arpad Ray)

--20cf307cffb8b192f304b176924c
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Nov 11, 2011 at 12:17 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> Hey Arpad, looking through the code you added to
> ext/standard/basic_functions.c it looks like you are doing some weird
> key handling in the shutdown function hash.
>
>
Hi Rasmus,

Thanks for the heads up, just fixed these.

Cheers,

Arpad



> In register_user_shutdown_function() you have:
>
> zend_hash_update(BG(user_shutdown_function_names), function_name,
> sizeof(function_name), shutdown_function_entry,
> sizeof(php_shutdown_function_entry), NULL)
>
> And in remove_user_shutdown_function() you have:
>
> zend_hash_del_key_or_index(BG(user_shutdown_function_names),
> function_name, sizeof(function_name), 0, HASH_DEL_KEY)
>
> In both cases function_name is a char* so sizeof(function_name) is
> always going to be the size of a char* on whatever architecture you are
> on. But the way hash keys work, it is the actual string that is the key
> and you should be passing the length of that string here.
>
> -Rasmus
>

--20cf307cffb8b192f304b176924c--