Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56265
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.215.170 cause and error)
Message-ID: <4EBC6986.3090709@lerdorf.com>
Date: Thu, 10 Nov 2011 16:17:10 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
CC: arpad@php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Hash problems in session-oo code
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Hey Arpad, looking through the code you added to
ext/standard/basic_functions.c it looks like you are doing some weird
key handling in the shutdown function hash.

In register_user_shutdown_function() you have:

zend_hash_update(BG(user_shutdown_function_names), function_name,
sizeof(function_name), shutdown_function_entry,
sizeof(php_shutdown_function_entry), NULL)

And in remove_user_shutdown_function() you have:

zend_hash_del_key_or_index(BG(user_shutdown_function_names),
function_name, sizeof(function_name), 0, HASH_DEL_KEY)

In both cases function_name is a char* so sizeof(function_name) is
always going to be the size of a char* on whatever architecture you are
on. But the way hash keys work, it is the actual string that is the key
and you should be passing the length of that string here.

-Rasmus