Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56255 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 75643 invoked from network); 10 Nov 2011 21:57:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Nov 2011 21:57:34 -0000 Authentication-Results: pb1.pair.com header.from=ralph@ralphschindler.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ralph@ralphschindler.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain ralphschindler.com from 209.85.213.170 cause and error) X-PHP-List-Original-Sender: ralph@ralphschindler.com X-Host-Fingerprint: 209.85.213.170 mail-yx0-f170.google.com Received: from [209.85.213.170] ([209.85.213.170:55653] helo=mail-yx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CA/31-00436-CC84CBE4 for ; Thu, 10 Nov 2011 16:57:33 -0500 Received: by yenm5 with SMTP id m5so2846165yen.29 for ; Thu, 10 Nov 2011 13:57:29 -0800 (PST) Received: by 10.100.171.1 with SMTP id t1mr3964430ane.143.1320962249103; Thu, 10 Nov 2011 13:57:29 -0800 (PST) Received: from ralph-mac.local (ip174-73-14-247.no.no.cox.net. [174.73.14.247]) by mx.google.com with ESMTPS id i67sm13856445yhm.16.2011.11.10.13.57.27 (version=SSLv3 cipher=OTHER); Thu, 10 Nov 2011 13:57:28 -0800 (PST) Message-ID: <4EBC48C7.2020202@ralphschindler.com> Date: Thu, 10 Nov 2011 15:57:27 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Rasmus Lerdorf CC: internals@lists.php.net References: <4EBC298A.3020103@ralphschindler.com> <4EBC2B5E.5060709@lerdorf.com> In-Reply-To: <4EBC2B5E.5060709@lerdorf.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue From: ralph@ralphschindler.com (Ralph Schindler) All of the existing tests run. I will make one change as per C. Jones request to use a const for the hard coded 1024 window (since it's used twice). Also, I am unable to run the php-tests.php with the -m (valgrind) on my mac, so I'll need to run those on linux before I commit. In the mean time, I'll request an account. Thanks! Ralph On 11/10/11 1:51 PM, Rasmus Lerdorf wrote: > On 11/10/2011 11:44 AM, Ralph Schindler wrote: >> Hey all, >> >> I've spent a bunch of time tracking down this issue (which was >> intermittent at best) and have identified the problem and have a patch >> for the solution. >> >> Details here: https://bugs.php.net/bug.php?id=60164 >> >> The attached patch is against trunk, PHP_5_4,& PHP_5_3. >> >> Seeing as though I've supplied patches in the past (see release notes), >> that I've spend significant time on understanding the Phar extension, >> and am able to fix issues there now, I'd like to be the one to commit >> this patch if internals is in agreement. >> >> So, how about it? > > Go for it. I assume the patch doesn't break any existing tests? > > -Rasmus