Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:56247 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56684 invoked from network); 10 Nov 2011 19:52:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Nov 2011 19:52:05 -0000 Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.213.170 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.213.170 mail-yx0-f170.google.com Received: from [209.85.213.170] ([209.85.213.170:61509] helo=mail-yx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 03/DF-01205-36B2CBE4 for ; Thu, 10 Nov 2011 14:52:04 -0500 Received: by yenm5 with SMTP id m5so2693204yen.29 for ; Thu, 10 Nov 2011 11:52:01 -0800 (PST) Received: by 10.68.73.98 with SMTP id k2mr17271315pbv.2.1320954721026; Thu, 10 Nov 2011 11:52:01 -0800 (PST) Received: from [192.168.200.5] (c-50-131-44-225.hsd1.ca.comcast.net. [50.131.44.225]) by mx.google.com with ESMTPS id km16sm23800728pbb.9.2011.11.10.11.51.59 (version=SSLv3 cipher=OTHER); Thu, 10 Nov 2011 11:51:59 -0800 (PST) Message-ID: <4EBC2B5E.5060709@lerdorf.com> Date: Thu, 10 Nov 2011 11:51:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Ralph Schindler CC: internals@lists.php.net References: <4EBC298A.3020103@ralphschindler.com> In-Reply-To: <4EBC298A.3020103@ralphschindler.com> X-Enigmail-Version: 1.4a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue From: rasmus@lerdorf.com (Rasmus Lerdorf) On 11/10/2011 11:44 AM, Ralph Schindler wrote: > Hey all, > > I've spent a bunch of time tracking down this issue (which was > intermittent at best) and have identified the problem and have a patch > for the solution. > > Details here: https://bugs.php.net/bug.php?id=60164 > > The attached patch is against trunk, PHP_5_4, & PHP_5_3. > > Seeing as though I've supplied patches in the past (see release notes), > that I've spend significant time on understanding the Phar extension, > and am able to fix issues there now, I'd like to be the one to commit > this patch if internals is in agreement. > > So, how about it? Go for it. I assume the patch doesn't break any existing tests? -Rasmus