Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:56151
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain akbkhome.com designates 202.81.246.113 as permitted sender)
Message-ID: <4EB8F63E.1000604@akbkhome.com>
Date: Tue, 08 Nov 2011 17:28:30 +0800
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Icedove/3.1.13
MIME-Version: 1.0
To: internals@lists.php.net
References: <CAEZPtU4B8N7Pte+YPmLiGiBC2jqQdOitjUgGgG9sv+tqEEHncg@mail.gmail.com> <4EB8B336.1040107@sugarcrm.com>
In-Reply-To: <4EB8B336.1040107@sugarcrm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] unsolved issues
From: alan@akbkhome.com (Alan Knowles)

Fixed that one.

https://bugs.php.net/patch-display.php?bug_id=55475&patch=final_patch_for_5_4_and_HEAD_v2&revision=latest 
<https://bugs.php.net/patch-display.php?bug_id=55475&patch=final_patch_for_5_4_and_HEAD_v2&revision=latest>

The alternative patch was to use the argument to enable/disable 
autoloader - which does not really solve the BC issues unfortunately.

The only discussion was to whether is_subclass_of should not support the 
extra arg, since there was not strong opinions either way, it's probably 
better to keep it simple and leave it the same as PHP5.3.

Regrds
Alan

On Tuesday, November 08, 2011 12:42 PM, Stas Malyshev wrote:
> Hi!
>
>> Is_a has a patch attached to the bug. Tests pass etc.
>
> I'm looking at bug 55475, there are two patches there:
>
> is_a_5.4_alternative and final_patch_for_5_4_and_HEAD. Which one do 
> you mean?
>
> The latter has:
>
> -    if (zend_lookup_class_ex(class_name, class_name_len, NULL, 0, &ce 
> TSRMLS_CC) == FAILURE) {
> +    if (zend_lookup_class_ex(class_name, class_name_len, NULL, &ce 
> TSRMLS_CC) == FAILURE) {
>
> which can't be right.
>