Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55932 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82383 invoked from network); 24 Oct 2011 17:51:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Oct 2011 17:51:50 -0000 Authentication-Results: pb1.pair.com header.from=dan@dracosplace.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=dan@dracosplace.com; spf=permerror; sender-id=softfail Received-SPF: error (pb1.pair.com: domain dracosplace.com from 74.125.82.170 cause and error) X-PHP-List-Original-Sender: dan@dracosplace.com X-Host-Fingerprint: 74.125.82.170 mail-wy0-f170.google.com Received: from [74.125.82.170] ([74.125.82.170:33841] helo=mail-wy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4A/20-14057-4B5A5AE4 for ; Mon, 24 Oct 2011 13:51:49 -0400 Received: by wyf23 with SMTP id 23so6843251wyf.29 for ; Mon, 24 Oct 2011 10:51:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.90.129 with SMTP id e1mr3379679wef.114.1319478705552; Mon, 24 Oct 2011 10:51:45 -0700 (PDT) Received: by 10.180.106.3 with HTTP; Mon, 24 Oct 2011 10:51:45 -0700 (PDT) Date: Mon, 24 Oct 2011 13:51:45 -0400 Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Subject: Patch to allow for Custom Application name in MSSQL connection From: dan@dracosplace.com (Dan Rowe) We currently use the php-mssql package (in conjunction with FreeTDS) for our setup. In other languages connecting to MSSQL we have come to rely on the Application Name being visible in Traces and the MSSQL profiler. In PHP it gets hard coded to 'PHP 5' even if there are multiple PHP applications connecting to the database. We have submitted a patch to add the ability for you to set the application name in the mssql_connect/mssql_pconnect function as an additional / optional parameter. This has been working great for us, so we wanted to see if we could contribute it back. Please let me know if there is any other information or anything else we could do to improve the patch/bug submission so that we can use this as a learning experience and improve future submissions. https://bugs.php.net/bug.php?id=60124 We have a few more non-related features we are vetting out in dev/production on our side prior to submitting. Also please let me know if this email should be routed to another list. Thanks, -Dan