Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55720
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1317917755.3367.14.camel@guybrush>
References: <4E7C764C.3000808@uw.no>
	<4E8DC9B4.7040809@uw.no>
	<4E8DCF7A.9050009@sugarcrm.com>
	<4E8DD05B.6060502@uw.no>
	<1317917755.3367.14.camel@guybrush>
Date: Fri, 7 Oct 2011 10:04:59 +0200
Message-ID: <CAEZPtU7_0wbwZCKny_pP8XHoD7wicBNL6fBDQe2xwPkjuXLKvQ@mail.gmail.com>
To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
Cc: "Daniel K." <dk@uw.no>, Stas Malyshev <smalyshev@sugarcrm.com>, internals@lists.php.net, 
	Etienne Kneuss <colder@php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] Fix for bug #55754
From: pierre.php@gmail.com (Pierre Joye)

hi,

2011/10/6 Johannes Schl=FCter <johannes@schlueters.de>:

> I think 5.3 is fine, too. But please extend the test a bit. The current
> one will pass even if the process segfaults. At least print something at
> the end.

I think it is not safe for 5.3. While the patch looks trivial or
harmless, it is in an area where the consequences of a new bug, even
for an edge case, can be very bad. The ratio risk/benefit is high,
especially when it is only about fixing a strict warning. I would
rather wait (maybe 5.4 last RC or final) before applying it to 5.3. We
don't need a 5.3.7/8 again :)

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org