Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55712 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90816 invoked from network); 6 Oct 2011 16:59:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Oct 2011 16:59:13 -0000 Authentication-Results: pb1.pair.com header.from=dk@uw.no; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=dk@uw.no; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain uw.no from 193.71.32.2 cause and error) X-PHP-List-Original-Sender: dk@uw.no X-Host-Fingerprint: 193.71.32.2 mx-1.vendo.no Linux 2.4/2.6 Received: from [193.71.32.2] ([193.71.32.2:55031] helo=mx-1.vendo.no) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BA/10-23519-F5EDD8E4 for ; Thu, 06 Oct 2011 12:59:12 -0400 Received: (qmail 4814 invoked from network); 6 Oct 2011 16:59:08 -0000 Received: from daniel.tbg.sysedata.no (HELO ?10.0.1.127?) (195.159.98.89) by mx-1.vendo.no with SMTP; 6 Oct 2011 16:59:08 -0000 Message-ID: <4E8DDE5C.6050207@uw.no> Date: Thu, 06 Oct 2011 18:59:08 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= CC: Stas Malyshev , internals@lists.php.net, Etienne Kneuss References: <4E7C764C.3000808@uw.no> <4E8DC9B4.7040809@uw.no> <4E8DCF7A.9050009@sugarcrm.com> <4E8DD05B.6060502@uw.no> <1317917755.3367.14.camel@guybrush> In-Reply-To: <1317917755.3367.14.camel@guybrush> Content-Type: multipart/mixed; boundary="------------030407010906040602000705" Subject: Re: [PHP-DEV] [PATCH] Fix for bug #55754 From: dk@uw.no ("Daniel K.") --------------030407010906040602000705 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/06/2011 06:15 PM, Johannes Schlüter wrote: > But please extend the test a bit. The current > one will pass even if the process segfaults. At least print something at > the end. Ah, so that's why some of the tests have 'echo "DONE";' at the end. New test-case uploaded, and attached. Daniel K. --------------030407010906040602000705 Content-Type: text/x-patch; name="bug55754-test-case_v2.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="bug55754-test-case_v2.patch" --- /dev/null 2011-07-31 22:39:26.003634828 +0200 +++ php-5.3.8/tests/lang/bug55754.phpt 2011-09-23 12:39:35.000000000 +0200 @@ -0,0 +1,14 @@ +--TEST-- +Bug #55754 (Only variables should be passed by reference for ZEND_SEND_PREFER_REF params) +--FILE-- + "a")); +current(array(0 => "a")); +current($arr); + +echo "DONE"; + +?> +--EXPECT-- +DONE --------------030407010906040602000705--