Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55710
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: "Daniel K." <dk@uw.no>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, internals@lists.php.net,
 Etienne Kneuss <colder@php.net>
In-Reply-To: <4E8DD05B.6060502@uw.no>
References: <4E7C764C.3000808@uw.no> <4E8DC9B4.7040809@uw.no>
	 <4E8DCF7A.9050009@sugarcrm.com>  <4E8DD05B.6060502@uw.no>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 06 Oct 2011 18:15:55 +0200
Message-ID: <1317917755.3367.14.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Fix for bug #55754
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Thu, 2011-10-06 at 17:59 +0200, Daniel K. wrote:
> On 10/06/2011 05:55 PM, Stas Malyshev wrote:
> > On 10/6/11 5:31 PM, Daniel K. wrote:
> >> A patch was appended, discussed, and improved, and I have uploaded a
> >> test-case, as well as a minimal patch that fixes the problem (attached)
> >> to the original bug-report.
> >>
> >> 	https://bugs.php.net/bug.php?id=55754
> >>
> >> The patch still applies to trunk, and I think it should be applied to
> >> the 5.3 and 5.4 branches as well.
> > 
> > As far as I can see, the patch looks good, so it can be applied to 5.4 
> > and trunk. If I don't hear any objections and nobody beats me to it, 
> > I'll do it in a couple of days (a bit busy now).
> 
> OK, thanks.
> 
> But what about 5.3? there is no ABI issue with this, just a spurious
> warning that goes away.

I think 5.3 is fine, too. But please extend the test a bit. The current
one will pass even if the process segfaults. At least print something at
the end.

johannes