Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55674 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98707 invoked from network); 30 Sep 2011 13:06:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Sep 2011 13:06:41 -0000 X-Host-Fingerprint: 217.114.211.68 unknown Date: Fri, 30 Sep 2011 09:06:39 -0400 Received: from [217.114.211.68] ([217.114.211.68:13614] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B3/20-30809-FDEB58E4 for ; Fri, 30 Sep 2011 09:06:39 -0400 To: internals@lists.php.net References: <4E80B195.7030400@sugarcrm.com> User-Agent: slrn/0.9.9p1 (SunOS) Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: X-Posted-By: 217.114.211.68 Subject: Re: [PHP-DEV] Merge fix for #54918 (r311748) to 5.4? From: dsp@php.net (David Soria Parra) On 2011-09-26, Stas Malyshev wrote: > Hi! > > On 9/26/11 1:42 AM, Pierre Joye wrote: >> It may be good to merge >> http://svn.php.net/viewvc?view=revision&revision=311748 to 5.4 too. >> This commit is about issues similar to the one describe in #54918. >> >> Any reason not to do it before next beta/rc? > > I'm not sure I understand this patch completely. I understand that if > one of the MINITs fails, this patch just continues. But we have tons of > code that assumes all basic MINITs worked - we always use variables > initialized in these MINITs without checking, etc. So does it really > make sense to continue if one of basic MINITs fail? On regular module > loading, MINIT failure is E_CORE_ERROR, why not here? I'm not sure about this too. Is there a reason why we continue to MINIT the other basic modules if one fails ?