Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55624 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 44493 invoked from network); 25 Sep 2011 02:00:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Sep 2011 02:00:52 -0000 Authentication-Results: pb1.pair.com smtp.mail=alan@akbkhome.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=alan@akbkhome.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain akbkhome.com designates 202.81.246.113 as permitted sender) X-PHP-List-Original-Sender: alan@akbkhome.com X-Host-Fingerprint: 202.81.246.113 246-113.netfront.net Received: from [202.81.246.113] ([202.81.246.113:53212] helo=246-113.netfront.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1D/82-12016-25B8E7E4 for ; Sat, 24 Sep 2011 22:00:51 -0400 Received: from wideboyhd.local ([192.168.0.28]) by akbkhome.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Mailfort v1.2) (envelope-from ) id 1R7e1O-0004cR-EA for internals@lists.php.net; Sun, 25 Sep 2011 10:00:46 +0800 Message-ID: <4E7E8B48.1060209@akbkhome.com> Date: Sun, 25 Sep 2011 10:00:40 +0800 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Thunderbird/3.1.13 MIME-Version: 1.0 To: internals@lists.php.net References: <4E790B82.6090805@akbkhome.com> <8C.A0.17510.E4DE97E4@pb1.pair.com> <1316615094.2810.5.camel@guybrush> <1316629502-sup-831@fewbar.com> <20110922134956.GA28577@panix.com> <1316709104-sup-2744@fewbar.com> <1316713382.1290.60.camel@guybrush> <4E7BBA23.2080001@lerdorf.com> <4E7BC6BF.6080702@akbkhome.com> <4E7C5A24.8080305@lerdorf.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-mailfort-sig: 94e32fca4eb472dfe4bd5ee03983ec83 Subject: Backward Compatibility RFC - was Re: [PHP-DEV] Re: is_a() - again - a better fix From: alan@akbkhome.com (Alan Knowles) Obviously I'd be keen to see this fix applied to 5.4 as the standard use case for is_a() is mixed return testing as '$x instanceof "somestring"' does not work. I've drafted up a BC RFC, if anyone want to contribute - feel free to edit.. https://wiki.php.net/rfc/backwards_compatibility? The "ideal" aim is that in future it would be better for the proposer of BC break to have a clear way to justify it rather than do so after the fact, or point to our rather long discussions. Regards Alan On Friday, September 23, 2011 06:17 PM, Pierre Joye wrote: > hi Rasmus, > > On Fri, Sep 23, 2011 at 12:06 PM, Rasmus Lerdorf wrote: > >> 1. Should we work up a basic PEAR test case that we can add to our >> tests? >> >> 2. Maybe we should think bigger and put more focus on having large PHP >> frameworks and apps test every RC. Currently we notify them of RCs >> and just hope someone will test and report back, but that obviously >> isn't working. We need a Daniel Brown-like approach to this. Someone >> who is really annoyingly persistent and will hunt down people to >> test RCs and keep a sign-off checklist of projects that have given >> a thumbs-up on an RC. > We do 2) already (while we are working on increasing the amount of > apps and frameworks being tested), as I was asking to revert this > patch between 5.3.7 and 5.3.8 back then pointing to our tests results > and numerous reports. The problem was not in the QA but in the > decision process. QA should have a kind of veto power in this case to > avoid arguing and still have BC breaks landing in stable releases. > >> Oh, and what do we do in 5.4? Philosophically I think Dmitry's original >> change was correct, but none of us realized all the code relying >> (arguably incorrectly) on the original behaviour. > It is not an easy decision, I would prefer to revert it there too as > it will break BC in 5.4 as well, obviously. > > Cheers,