Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55623
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAAa2siG4c8rbDR1VBaJZBc2bGpccaY3qHKagAuVkA5-gMkX3A@mail.gmail.com>
References: <CAAAa2siG4c8rbDR1VBaJZBc2bGpccaY3qHKagAuVkA5-gMkX3A@mail.gmail.com>
Date: Sat, 24 Sep 2011 14:50:18 -0300
Message-ID: <CA+5g0SJETt5pdJqpxwK9Ot+j9rErfEE_mchqDcRfes0oF17wew@mail.gmail.com>
To: Alexey Shein <confik@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is
 provided in run-tests.php
From: felipensp@gmail.com (Felipe Pena)

2011/9/8 Alexey Shein <confik@gmail.com>:
> Hello!
> I've made some improvements to run-tests.php:
> 1) Autoguessing TEST_PHP_EXECUTABLE and TEST_PHP_CGI_EXECUTABLE if
> they're not provided, i.e. assume they have value 'auto'. You can
> still pass your own value as usual.
> 2) Added option -n (use no php.ini) to the shebang line
> (#!/usr/bin/php -n) so it would run more reliably on some hosts. My
> Ubuntu setup did not have E letter in variables_order (i.e.
> variables_order=GPCS) so $_ENV array was empty and some tests were
> skipped when they could be run.
> 3) Some better error handling of wrong paths
>
> So now you can run run-tests.php with just
> $ ./run-tests.php ext
> instead of
> $ TEST_PHP_EXECUTABLE=auto php -n run-tests.php ext
>
> You can also run run-tests.php from sub-dir, it will correctly guess
> 'auto' as well:
> $ cd ext/
> $ ../run-tests.php zlib
>
> Please, review this patch and, if there's no objections, I will
> prepare 5.4 and 5.3 versions too.
>
> --
> Regards,
> Shein Alexey
>

+1

I have no tried the patch, but the additions sounds good to me.

-- 
Regards,
Felipe Pena