Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55622
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4E7CD221.7020309@oracle.com>
References: <4E790B82.6090805@akbkhome.com>
	<8C.A0.17510.E4DE97E4@pb1.pair.com>
	<1316615094.2810.5.camel@guybrush>
	<CAEZPtU51Hk+kmLhNqnCjDbRuW2t7QUumQX2qotPKLbeJkD1rAA@mail.gmail.com>
	<1316629502-sup-831@fewbar.com>
	<CAJW__o0WKqh0f71+r4m7ZMf2XhyJT3brs=9Phz=jFHtn=OQkaA@mail.gmail.com>
	<20110922134956.GA28577@panix.com>
	<CAJW__o0=-_BUaWMPw16vJPgeNFA86P=EQ1WWsH8kgmJWhGv42Q@mail.gmail.com>
	<1316709104-sup-2744@fewbar.com>
	<1316713382.1290.60.camel@guybrush>
	<CAEZPtU7573By7tcdQB0CaWVZVULD1dxAH-qugFULSXzHwQT7yg@mail.gmail.com>
	<4E7BBA23.2080001@lerdorf.com>
	<4E7BC6BF.6080702@akbkhome.com>
	<4E7C5A24.8080305@lerdorf.com>
	<CACwt+Jd0cn0TjV3OOpwn_rcJt4XJTWKSDGX8HYQex0eR_M_Rqw@mail.gmail.com>
	<4E7C5CE9.40000@lerdorf.com>
	<B7.78.29222.0B0BC7E4@pb1.pair.com>
	<4E7CBE25.5080506@oracle.com>
	<4E7CCD49.4040502@lerdorf.com>
	<4E7CCDF6.3060206@oracle.com>
	<4E7CD0F7.8090304@lerdorf.com>
	<4E7CD221.7020309@oracle.com>
Date: Sat, 24 Sep 2011 14:07:44 +0200
Message-ID: <CADNQb0Wwm5=59ZJNDZj-n9w_tPHZAg698=RP1THYKR4dT3ASng@mail.gmail.com>
To: Christopher Jones <christopher.jones@oracle.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: is_a() - again - a better fix
From: hannes.magnusson@gmail.com (Hannes Magnusson)

On Fri, Sep 23, 2011 at 20:38, Christopher Jones
<christopher.jones@oracle.com> wrote:
>
>
> On 09/23/2011 11:33 AM, Rasmus Lerdorf wrote:
>>
>> On 09/23/2011 08:20 PM, Christopher Jones wrote:
>>>
>>>
>>> On 09/23/2011 11:17 AM, Rasmus Lerdorf wrote:
>>>>
>>>> On 09/23/2011 07:13 PM, Christopher Jones wrote:
>>>>>
>>>>>
>>>>> On 09/23/2011 09:15 AM, Matthew Weier O'Phinney wrote:
>>>>>
>>>>>> I could also see this being an interesting peer-pressure move --
>>>>>> "First
>>>>>> to test!", "We tested last week; how come _you_ haven't?", etc.
>>>>>
>>>>> Speaking of testing, the commit
>>>>> http://svn.php.net/viewvc?view=3Drevision&revision=3D317183
>>>>> doesn't have any...
>>>>>
>>>>> Who amongst the vocal supporters of the change is volunteering for th=
is
>>>>> task?
>>>>
>>>> I committed a test about 2 hours before you posted this message:
>>>>
>>>> http://svn.php.net/viewvc?view=3Drevision&revision=3D317208
>>>>
>>>> -Rasmus
>>>
>>> I don't see is_a or is_subclass_of in that test. =C2=A0Did I miss somet=
hing?
>>
>> Yeah, got the wrong commit when I brought up that link. Had a cached
>> copy of my fix for 55767 and the wifi is wonky here.
>
> No probs.
>
> Let's see if the people who speak about PHP & testing & compatibility
> actually
> do care enough about it to submit some tests.


Just for the record, the original behavior was covered by tests, but
the test was changed when introducing the new behavior.

And that is something we actually do quite a bit. Modify existing
tests to fit new behavior..

The problem is our tests are all over the place. Testing waaay to many
things at once, making it very difficult to spot actually wrong
behaviors and broken functionality :(

-Hannes