Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55599
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.170 as permitted sender)
MIME-Version: 1.0
Sender: patrick.allaert@gmail.com
In-Reply-To: <4E7C5A24.8080305@lerdorf.com>
References: <4E790B82.6090805@akbkhome.com>
	<8C.A0.17510.E4DE97E4@pb1.pair.com>
	<1316615094.2810.5.camel@guybrush>
	<CAEZPtU51Hk+kmLhNqnCjDbRuW2t7QUumQX2qotPKLbeJkD1rAA@mail.gmail.com>
	<1316629502-sup-831@fewbar.com>
	<CAJW__o0WKqh0f71+r4m7ZMf2XhyJT3brs=9Phz=jFHtn=OQkaA@mail.gmail.com>
	<20110922134956.GA28577@panix.com>
	<CAJW__o0=-_BUaWMPw16vJPgeNFA86P=EQ1WWsH8kgmJWhGv42Q@mail.gmail.com>
	<1316709104-sup-2744@fewbar.com>
	<1316713382.1290.60.camel@guybrush>
	<CAEZPtU7573By7tcdQB0CaWVZVULD1dxAH-qugFULSXzHwQT7yg@mail.gmail.com>
	<4E7BBA23.2080001@lerdorf.com>
	<4E7BC6BF.6080702@akbkhome.com>
	<4E7C5A24.8080305@lerdorf.com>
Date: Fri, 23 Sep 2011 12:13:40 +0200
Message-ID: <CACwt+Jd0cn0TjV3OOpwn_rcJt4XJTWKSDGX8HYQex0eR_M_Rqw@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Alan Knowles <alan@akbkhome.com>, internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: is_a() - again - a better fix
From: patrickallaert@php.net (Patrick ALLAERT)

2011/9/23 Rasmus Lerdorf <rasmus@lerdorf.com>:
> On 09/23/2011 01:37 AM, Alan Knowles wrote:
>> This patch adds an extra parameter 'allow_string' to is_a (default off)
>> and is_subclass_of (default on) ,
>>
>> https://bugs.php.net/patch-display.php?bug_id=3D55475&patch=3DIs_a_with_=
allow_string_argument_v3&revision=3Dlatest
>> <https://bugs.php.net/patch-display.php?bug_id=3D55475&patch=3DIs_a_with=
_allow_string_argument_v3&revision=3Dlatest>
>>
>>
>> It also explains why their behaviour is different. This is a clean, no
>> BC break, solution. let's move on and just fix this.
>
> Ok, executive decision made. Patch committed. We obviously screwed up in
> making this change in the 5_3 branch and since at least one distro has
> held off in pushing out newer 5.3 builds in order to not break every
> existing PEAR package, it is completely clear to me that this needed to
> be fixed in 5.3.
>
> So, a couple of ideas to address cases like this in the future.
>
> 1. Should we work up a basic PEAR test case that we can add to our
> =C2=A0 tests?
>
> 2. Maybe we should think bigger and put more focus on having large PHP
> =C2=A0 frameworks and apps test every RC. Currently we notify them of RCs
> =C2=A0 and just hope someone will test and report back, but that obviousl=
y
> =C2=A0 isn't working. We need a Daniel Brown-like approach to this. Someo=
ne
> =C2=A0 who is really annoyingly persistent and will hunt down people to
> =C2=A0 test RCs and keep a sign-off checklist of projects that have given
> =C2=A0 a thumbs-up on an RC.

Solution 2: +1

Having a Jenkins instance which would run major framework testsuites
against the different versions of PHP?

> Oh, and what do we do in 5.4? Philosophically I think Dmitry's original
> change was correct, but none of us realized all the code relying
> (arguably incorrectly) on the original behaviour.
>
> -Rasmus
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php