Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55598 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77948 invoked from network); 23 Sep 2011 10:06:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Sep 2011 10:06:36 -0000 Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.214.42 cause and error) X-PHP-List-Original-Sender: rasmus@lerdorf.com X-Host-Fingerprint: 209.85.214.42 mail-bw0-f42.google.com Received: from [209.85.214.42] ([209.85.214.42:50492] helo=mail-bw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E6/C4-46707-92A5C7E4 for ; Fri, 23 Sep 2011 06:06:34 -0400 Received: by bkar4 with SMTP id r4so3482280bka.29 for ; Fri, 23 Sep 2011 03:06:30 -0700 (PDT) Received: by 10.204.135.145 with SMTP id n17mr2337803bkt.39.1316772389930; Fri, 23 Sep 2011 03:06:29 -0700 (PDT) Received: from [172.17.7.157] ([212.24.153.156]) by mx.google.com with ESMTPS id ex8sm4145816bkc.2.2011.09.23.03.06.27 (version=SSLv3 cipher=OTHER); Fri, 23 Sep 2011 03:06:28 -0700 (PDT) Message-ID: <4E7C5A24.8080305@lerdorf.com> Date: Fri, 23 Sep 2011 12:06:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Alan Knowles CC: internals@lists.php.net References: <4E790B82.6090805@akbkhome.com> <8C.A0.17510.E4DE97E4@pb1.pair.com> <1316615094.2810.5.camel@guybrush> <1316629502-sup-831@fewbar.com> <20110922134956.GA28577@panix.com> <1316709104-sup-2744@fewbar.com> <1316713382.1290.60.camel@guybrush> <4E7BBA23.2080001@lerdorf.com> <4E7BC6BF.6080702@akbkhome.com> In-Reply-To: <4E7BC6BF.6080702@akbkhome.com> X-Enigmail-Version: 1.2.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: is_a() - again - a better fix From: rasmus@lerdorf.com (Rasmus Lerdorf) On 09/23/2011 01:37 AM, Alan Knowles wrote: > This patch adds an extra parameter 'allow_string' to is_a (default off) > and is_subclass_of (default on) , > > https://bugs.php.net/patch-display.php?bug_id=55475&patch=Is_a_with_allow_string_argument_v3&revision=latest > > > > It also explains why their behaviour is different. This is a clean, no > BC break, solution. let's move on and just fix this. Ok, executive decision made. Patch committed. We obviously screwed up in making this change in the 5_3 branch and since at least one distro has held off in pushing out newer 5.3 builds in order to not break every existing PEAR package, it is completely clear to me that this needed to be fixed in 5.3. So, a couple of ideas to address cases like this in the future. 1. Should we work up a basic PEAR test case that we can add to our tests? 2. Maybe we should think bigger and put more focus on having large PHP frameworks and apps test every RC. Currently we notify them of RCs and just hope someone will test and report back, but that obviously isn't working. We need a Daniel Brown-like approach to this. Someone who is really annoyingly persistent and will hunt down people to test RCs and keep a sign-off checklist of projects that have given a thumbs-up on an RC. Oh, and what do we do in 5.4? Philosophically I think Dmitry's original change was correct, but none of us realized all the code relying (arguably incorrectly) on the original behaviour. -Rasmus