Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55518
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender)
MIME-Version: 1.0
Sender: ekneuss@gmail.com
In-Reply-To: <op.v11rqdgiidpuyk@clk-0081.mshome.net>
References: <CAKUjMCXiYc63NKsUuYWXT-A-aPabdPV6142LP9h4-c=2aUxW=w@mail.gmail.com>
	<4E74E5A0.2030006@sugarcrm.com>
	<alpine.DEB.2.02.1109181708480.3630@whisky>
	<4E76320F.6010904@sugarcrm.com>
	<CAF+90c8oZ4ghsFBa7jHtp_AKqD0N0cDhMycpjFTpCkLV9qRsqQ@mail.gmail.com>
	<4E764137.9080507@sugarcrm.com>
	<op.v11rqdgiidpuyk@clk-0081.mshome.net>
Date: Mon, 19 Sep 2011 11:01:32 +0200
Message-ID: <CACQesk5iSTqw4r4OVyCG5WYyYz3xie4ionhRBVj2-r_iDgznQg@mail.gmail.com>
To: Gustavo Lopes <glopes@nebm.ist.utl.pt>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=001517448364ebd13c04ad4796e5
Subject: Re: [PHP-DEV] __constructor parameter limitations.
From: colder@php.net (Etienne Kneuss)

--001517448364ebd13c04ad4796e5
Content-Type: text/plain; charset=UTF-8

Hi,

On Mon, Sep 19, 2011 at 10:40, Gustavo Lopes <glopes@nebm.ist.utl.pt> wrote:

> Em Sun, 18 Sep 2011 20:06:31 +0100, Stas Malyshev <smalyshev@sugarcrm.com>
> escreveu:
>
>  On 9/18/11 11:23 AM, Nikita Popov wrote:
>>
>>> to tell you: I need this and that method accepting these and these
>>> arguments to work correctly. If the signature isn't enforced, this
>>> doesn't make sense anymore. You could just as well drop the signature
>>> from abstract method definitions, as it's pointless then.
>>>
>>
>> No it is not. The signature tells "this method would accept certain
>> arguments". If you call it with these arguments, it would work. However,
>> there's no promise to never extend the cases where it works - it goes
>> contrary to the whole point of OOP to say "I will never loosen preconditions
>> on my methods".
>>
>
> While this is true, we should be a bit pragmatic here.
>
> If the subclass method specifies less parameters, it is very likely a
> mistake. It's not usual (certainly it's not more frequent than a mistake
> being the case) for arguments to be simply intentionally ignored. In fact, I
> don't know of any popular language that implements this type of
> contravariance. Plus, consider the case in which the superclass takes an
> argument by reference:
>
> function increment(&$foo) { $foo = $foo + 1; }
>
> It is obvious that in this case a subclass override that takes no arguments
> cannot possibly satisfy the contract of the original method. That is to say,
> by ref arguments are also used for postconditions.
>

Sure, but you mix two things here, references would have to be handled
specifically, and we would not allow to specify less args by ref.

There is simply no reason for disallowing this with nornal args though.
Imagine the following code:

interface Foo { public function plop ($a,$b,$c,$d) }

class A implements Foo {
   public function plop() {
      $args = func_get_args();
      // ...
   }
}

This is perfectly valid PHP code, there is no valid usage of Foo that will
not work with A... So to me this restriction seems really arbitrary.
And I don;t believe missing an argument in the declaration of a method,
using it in the body of the method and not realising it is so much of a
common error that it would warrant this.


>
> That said, I think the only rules worth implementing are:
>
> * Allow arguments with a supertype. For instance, this should give no
> warning:


> <?php
> class A {}
> class B extends A {}
> class C { function g(B $b) {} }
> class D extends C { function g(A $a) { } }
>
> * Allow extra parameters with a default value (implemented):
>
> <?php
> class C { function g($a) {} }
> class D extends C { function g($a,$b=true) { } }
>
> --
> Gustavo Lopes
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
Etienne Kneuss
http://www.colder.ch

--001517448364ebd13c04ad4796e5--