Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55474 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 22155 invoked from network); 16 Sep 2011 12:30:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Sep 2011 12:30:47 -0000 Authentication-Results: pb1.pair.com smtp.mail=rquadling@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=rquadling@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.177 as permitted sender) X-PHP-List-Original-Sender: rquadling@gmail.com X-Host-Fingerprint: 209.85.216.177 mail-qy0-f177.google.com Received: from [209.85.216.177] ([209.85.216.177:46592] helo=mail-qy0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 52/90-16440-571437E4 for ; Fri, 16 Sep 2011 08:30:46 -0400 Received: by qyk31 with SMTP id 31so3864795qyk.8 for ; Fri, 16 Sep 2011 05:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=IjaZtXrbtqyR/6Gvksyl0tq5seHuRuTb/OTCE2ytd2o=; b=fzcCMj9ZzmPuz15/yoX4JgkSQcul4TduS6vZjsuJEpuIqdSvGdHZViqAHlnNDtXLAA GTwoUgIXbIkkjithM7w8X+cFrQhCfCCSlaLjNhP/m3f2ah+aU15P77ld+DFAtR15U6MA 5ThmHEIxBmDaExIUPgiTirn7V/zki9/C2QzCQ= Received: by 10.229.91.16 with SMTP id k16mr1914473qcm.104.1316176241080; Fri, 16 Sep 2011 05:30:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.100.81 with HTTP; Fri, 16 Sep 2011 05:30:21 -0700 (PDT) Reply-To: RQuadling@GMail.com In-Reply-To: <4E72744D.3070306@gmail.com> References: <4E72744D.3070306@gmail.com> Date: Fri, 16 Sep 2011 13:30:21 +0100 Message-ID: To: =?UTF-8?B?w4FuZ2VsIEdvbnrDoWxleg==?= Cc: PHP internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] A couple of missing directories if configure.js is forgotten. From: rquadling@gmail.com (Richard Quadling) 2011/9/15 =C3=81ngel Gonz=C3=A1lez : > Richard Quadling wrote: >> >> Hi. >> >> Sometimes I remove Release prior to nmake to make sure everything builds >> clean. >> >> 2 directories fail to get build >> >> Release\win32 >> Release\devel >> >> The attached patch fixes that. >> >> - =C2=A0 =C2=A0 =C2=A0 @for %D in ($(BUILD_DIRS_SUB)) do @if not exist %= D @mkdir %D> =C2=A0NUL >> + =C2=A0 =C2=A0 =C2=A0 @for %D in ($(BUILD_DIRS_SUB) devel win32) do @if= not exist %D >> @mkdir %D> =C2=A0NUL >> >> >> >> Richard. > > Shouldn't you add them to BUILD_DIRS_SUB instead? > > Yep! See bug https://bugs.php.net/bug.php?id=3D55710 with latest patch. It was an edge case for the win32 directory caused by having pecl/win32service configured for building. Any extension with win32 in it would have caused the issue. --=20 Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea